nchebrov/stellars-jupyterhub-ds
1
0
Fork 0
mirror of https://github.com/stellarshenson/stellars-jupyterhub-ds.git synced 2026-03-08 06:00:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: update custom branding with startup callback for surviving servers

Browse Source
This commit is contained in:
stellarshenson
2026-02-09 13:40:38 +01:00
parent 4bd130b11e
commit da6cb127d8
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docs/custom-branding.md
View File

@@ -50,11 +50,11 @@ JupyterHub auto-prefixes all `extra_handlers` routes with `/hub/`. CHP forwards
### Route Lifecycle
- CHP routes are added in `pre_spawn_hook` before each spawn (idempotent - CHP overwrites existing routes)
- Tornado handler is injected once (guarded by `app._favicon_handler_injected` flag)
- **New spawns**: `pre_spawn_hook` registers per-user CHP route before each spawn (idempotent)
- **Surviving servers**: A one-shot `IOLoop.current().add_callback()` startup callback iterates all active servers and registers their CHP routes immediately after the event loop starts - this covers servers that were already running when JupyterHub restarted
- Tornado handler is injected once (guarded by `app._favicon_handler_injected` flag) by whichever path executes first
- Stale routes when servers stop are harmless (hub is always running to handle them)
- No cleanup needed
- Servers already running when JupyterHub restarts will not have CHP routes until their next stop/start cycle
### Conditionality