From a5ffcdb1f88ab52fb34d8e8a66680759e98e2eee Mon Sep 17 00:00:00 2001
From: stellarshenson <konrad.jelen@gmail.com>
Date: Sun, 10 Aug 2025 04:31:59 +0200
Subject: [PATCH] updated to have certificates mounted externally

---
 {services/jupyterhub/templates/certs => certs}/README.md | 3 +++
 {services/jupyterhub/templates/certs => certs}/certs.yml | 0
 compose.yml                                              | 2 +-
 services/jupyterhub/Dockerfile.jupyterhub                | 1 -
 4 files changed, 4 insertions(+), 2 deletions(-)
 rename {services/jupyterhub/templates/certs => certs}/README.md (69%)
 rename {services/jupyterhub/templates/certs => certs}/certs.yml (100%)

diff --git a/services/jupyterhub/templates/certs/README.md b/certs/README.md
similarity index 69%
rename from services/jupyterhub/templates/certs/README.md
rename to certs/README.md
index d38bde3..0d6d715 100644
--- a/services/jupyterhub/templates/certs/README.md
+++ b/certs/README.md
@@ -1,2 +1,5 @@
 this is where certificates for jupyterlab and jupyterhub should be uploaded
 this directory will be mounted under /mnt/certs
+
+- server.key - private key
+- server.crt - certificate
diff --git a/services/jupyterhub/templates/certs/certs.yml b/certs/certs.yml
similarity index 100%
rename from services/jupyterhub/templates/certs/certs.yml
rename to certs/certs.yml
diff --git a/compose.yml b/compose.yml
index 273b0ef..ce1128b 100644
--- a/compose.yml
+++ b/compose.yml
@@ -50,9 +50,9 @@ services:
     container_name: ${COMPOSE_PROJECT_NAME:-stellars-jupyterhub-ds}-jupyterhub
     volumes:
       - ./config/jupyterhub_config.py:/srv/jupyterhub/jupyterhub_config.py:ro # config file (read only)
+      - ./certs:/mnt/certs # SSL certificates
       - /var/run/docker.sock:/var/run/docker.sock:rw # docker socket to use spawner
       - jupyterhub_data:/data # database and cookie secrets
-      - jupyterhub_certs:/mnt/certs # SSL certificates
       - jupyterhub_shared:/mnt/shared # shared volume across environments
       - /var/run/docker.sock:/var/run/docker.sock:ro # for nvidia autodetection
     environment:
diff --git a/services/jupyterhub/Dockerfile.jupyterhub b/services/jupyterhub/Dockerfile.jupyterhub
index 1b7e22d..ba903a7 100644
--- a/services/jupyterhub/Dockerfile.jupyterhub
+++ b/services/jupyterhub/Dockerfile.jupyterhub
@@ -33,7 +33,6 @@ EOF
 ## copy resources
 COPY --chmod=755  ./conf/bin/*.sh ./conf/bin/*.py /
 COPY --chmod=755  ./conf/bin/start-platform.d /start-platform.d
-COPY ./templates/certs /mnt/certs
 
 ## install dockerspawner, nativeauthenticator
 RUN pip install -U --no-cache-dir \