From 1db8ed112958ca62ec4b0abf46ae2bb3aeb7550e Mon Sep 17 00:00:00 2001 From: stellarshenson Date: Sun, 18 Jan 2026 18:18:29 +0100 Subject: [PATCH] feat: rename JUPYTERHUB_SERVICE_GLANCES to JUPYTERHUB_SERVICE_RESOURCES_MONITOR --- .claude/CLAUDE.md | 2 +- .claude/JOURNAL.md | 3 +++ README.md | 2 +- compose.yml | 2 +- config/jupyterhub_config.py | 4 ++-- services/jupyterhub/conf/settings_dictionary.yml | 4 ++-- 6 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.claude/CLAUDE.md b/.claude/CLAUDE.md index f2155c4..9b42aee 100644 --- a/.claude/CLAUDE.md +++ b/.claude/CLAUDE.md @@ -70,7 +70,7 @@ This Python configuration file controls all JupyterHub behavior: - `JUPYTERHUB_GPU_ENABLED`: GPU mode - `0` (disabled), `1` (enabled), `2` (auto-detect) - `JUPYTERHUB_SSL_ENABLED`: Direct SSL config - `0` (disabled), `1` (enabled) - `JUPYTERHUB_SERVICE_MLFLOW`: Enable MLflow tracking (`0`/`1`) -- `JUPYTERHUB_SERVICE_GLANCES`: Enable resource monitor (`0`/`1`) +- `JUPYTERHUB_SERVICE_RESOURCES_MONITOR`: Enable resource monitor (`0`/`1`) - `JUPYTERHUB_SERVICE_TENSORBOARD`: Enable TensorBoard (`0`/`1`) - `JUPYTERHUB_NVIDIA_IMAGE`: Image for GPU detection (default: `nvidia/cuda:12.9.1-base-ubuntu24.04`) diff --git a/.claude/JOURNAL.md b/.claude/JOURNAL.md index b456c8d..93bd32d 100644 --- a/.claude/JOURNAL.md +++ b/.claude/JOURNAL.md @@ -165,3 +165,6 @@ This journal tracks substantive work on documents, diagrams, and documentation c 54. **Task - Enhance traefik-host-based-routing template**: Major improvements to deployment template with CIFS support and certificate installers
**Result**: Added optional CIFS mount support via compose_cifs.yml and .env.example (ENABLE_CIFS=1), created install_cert.sh for Linux (multi-distro: Debian/Ubuntu, RHEL/CentOS, Arch, Alpine, macOS) and enhanced install_cert.bat for Windows with folder argument and help flags, fixed compose_override.yml stray quote and added JUPYTERHUB_IDLE_CULLER_ENABLED/JUPYTERHUB_SIGNUP_ENABLED defaults, enhanced generate-certs.sh with generic CN for browser compatibility and verification output, updated start.sh/stop.sh to load .env and conditionally include compose_cifs.yml, updated README with CIFS instructions and certificate installation commands, added .env to .gitignore + +55. **Task - Rename GLANCES to RESOURCES_MONITOR**: Renamed environment variable for clarity
+ **Result**: Renamed JUPYTERHUB_SERVICE_GLANCES to JUPYTERHUB_SERVICE_RESOURCES_MONITOR across compose.yml, jupyterhub_config.py, settings_dictionary.yml, README.md, and CLAUDE.md diff --git a/README.md b/README.md index de1c216..eeeb63d 100644 --- a/README.md +++ b/README.md @@ -106,7 +106,7 @@ graph TB subgraph SVCEN["JUPYTERHUB_SERVICE_*
Passed to Lab as env"] direction LR MLF[JUPYTERHUB_SERVICE_MLFLOW] - GLN[JUPYTERHUB_SERVICE_GLANCES] + RES[JUPYTERHUB_SERVICE_RESOURCES_MONITOR] TNS[JUPYTERHUB_SERVICE_TENSORBOARD] SVC_MORE[...] end diff --git a/compose.yml b/compose.yml index e82e840..d024638 100644 --- a/compose.yml +++ b/compose.yml @@ -72,7 +72,7 @@ services: - JUPYTERHUB_NVIDIA_IMAGE=nvidia/cuda:13.0.2-base-ubuntu24.04 # GPU detection image # User environment services - JUPYTERHUB_SERVICE_MLFLOW=1 # MLflow experiment tracking - - JUPYTERHUB_SERVICE_GLANCES=1 # system resources monitor + - JUPYTERHUB_SERVICE_RESOURCES_MONITOR=1 # system resources monitor - JUPYTERHUB_SERVICE_TENSORBOARD=1 # TensorFlow training tracker # Misc - TF_CPP_MIN_LOG_LEVEL=3 # TensorFlow verbosity diff --git a/config/jupyterhub_config.py b/config/jupyterhub_config.py index 4b93feb..e0ffc58 100644 --- a/config/jupyterhub_config.py +++ b/config/jupyterhub_config.py @@ -188,7 +188,7 @@ def detect_nvidia(nvidia_autodetect_image='nvidia/cuda:12.9.1-base-ubuntu24.04') JUPYTERHUB_SSL_ENABLED = int(os.environ.get("JUPYTERHUB_SSL_ENABLED", 1)) JUPYTERHUB_GPU_ENABLED = int(os.environ.get("JUPYTERHUB_GPU_ENABLED", 2)) JUPYTERHUB_SERVICE_MLFLOW = int(os.environ.get("JUPYTERHUB_SERVICE_MLFLOW", 1)) -JUPYTERHUB_SERVICE_GLANCES = int(os.environ.get("JUPYTERHUB_SERVICE_GLANCES", 1)) +JUPYTERHUB_SERVICE_RESOURCES_MONITOR = int(os.environ.get("JUPYTERHUB_SERVICE_RESOURCES_MONITOR", 1)) JUPYTERHUB_SERVICE_TENSORBOARD = int(os.environ.get("JUPYTERHUB_SERVICE_TENSORBOARD", 1)) JUPYTERHUB_SIGNUP_ENABLED = int(os.environ.get("JUPYTERHUB_SIGNUP_ENABLED", 1)) # 0=disabled, 1=enabled JUPYTERHUB_IDLE_CULLER_ENABLED = int(os.environ.get("JUPYTERHUB_IDLE_CULLER_ENABLED", 0)) @@ -235,7 +235,7 @@ if c is not None: 'MLFLOW_HOST':'0.0.0.0', # new 3.5 mlflow launched with guinicorn requires this 'MLFLOW_WORKERS':1, 'JUPYTERHUB_SERVICE_MLFLOW': JUPYTERHUB_SERVICE_MLFLOW, - 'JUPYTERHUB_SERVICE_GLANCES': JUPYTERHUB_SERVICE_GLANCES, + 'JUPYTERHUB_SERVICE_RESOURCES_MONITOR': JUPYTERHUB_SERVICE_RESOURCES_MONITOR, 'JUPYTERHUB_SERVICE_TENSORBOARD': JUPYTERHUB_SERVICE_TENSORBOARD, 'JUPYTERHUB_GPU_ENABLED': JUPYTERHUB_GPU_ENABLED, 'ENABLE_GPUSTAT': JUPYTERHUB_GPU_ENABLED, diff --git a/services/jupyterhub/conf/settings_dictionary.yml b/services/jupyterhub/conf/settings_dictionary.yml index d52a1dd..1024c7a 100644 --- a/services/jupyterhub/conf/settings_dictionary.yml +++ b/services/jupyterhub/conf/settings_dictionary.yml @@ -51,8 +51,8 @@ Services: description: MLflow service (0=disabled, 1=enabled) default: "1" - - name: JUPYTERHUB_SERVICE_GLANCES - description: Glances service (0=disabled, 1=enabled) + - name: JUPYTERHUB_SERVICE_RESOURCES_MONITOR + description: Resources monitor service (0=disabled, 1=enabled) default: "1" - name: JUPYTERHUB_SERVICE_TENSORBOARD