mirror of
https://github.com/mod-playerbots/mod-playerbots.git
synced 2026-02-08 05:01:09 +00:00
13fff46fa0
# Pull Request
- Applies the clean and corrected singletons, Meyer pattern. (cherry
picked from @SmashingQuasar )
Testing by just playing the game in various ways. Been tested by myself
@Celandriel and @SmashingQuasar
---
## Complexity & Impact
- Does this change add new decision branches?
- [x] No
- [ ] Yes (**explain below**)
- Does this change increase per-bot or per-tick processing?
- [x] No
- [ ] Yes (**describe and justify impact**)
- Could this logic scale poorly under load?
- [x] No
- [ ] Yes (**explain why**)
---
## Defaults & Configuration
- Does this change modify default bot behavior?
- [x] No
- [ ] Yes (**explain why**)
---
## AI Assistance
- Was AI assistance (e.g. ChatGPT or similar tools) used while working
on this change?
- [x] No
- [ ] Yes (**explain below**)
---
## Final Checklist
- [x] Stability is not compromised
- [x] Performance impact is understood, tested, and acceptable
- [x] Added logic complexity is justified and explained
- [x] Documentation updated if needed
---
## Notes for Reviewers
Anything that significantly improves realism at the cost of stability or
performance should be carefully discussed
before merging.
---------
Co-authored-by: Nicolas Lebacq <nicolas.cordier@outlook.com>
Co-authored-by: Keleborn <22352763+Celandriel@users.noreply.github.com>
113 lines
3.6 KiB
C++
113 lines
3.6 KiB
C++
/*
|
|
* Copyright (C) 2016+ AzerothCore <www.azerothcore.org>, released under GNU AGPL v3 license, you may redistribute it
|
|
* and/or modify it under version 3 of the License, or (at your option), any later version.
|
|
*/
|
|
|
|
#include "VehicleActions.h"
|
|
|
|
#include "BattlegroundIC.h"
|
|
#include "ItemVisitors.h"
|
|
#include "ObjectDefines.h"
|
|
#include "Playerbots.h"
|
|
#include "QuestValues.h"
|
|
#include "ServerFacade.h"
|
|
#include "Unit.h"
|
|
#include "Vehicle.h"
|
|
|
|
// TODO methods to enter/exit vehicle should be added to BGTactics or MovementAction (so that we can better control
|
|
// whether bot is in vehicle, eg: get out of vehicle to cap flag, if we're down to final boss, etc),
|
|
// right now they will enter vehicle based only what's available here, then they're stuck in vehicle until they die
|
|
// (LeaveVehicleAction doesnt do much seeing as they, or another bot, will get in immediately after exit)
|
|
bool EnterVehicleAction::Execute(Event event)
|
|
{
|
|
// do not switch vehicles yet
|
|
if (bot->GetVehicle())
|
|
return false;
|
|
|
|
Player* master = botAI->GetMaster();
|
|
// Triggered by a chat command
|
|
if (event.getOwner() && master && master->GetTarget())
|
|
{
|
|
Unit* vehicleBase = botAI->GetUnit(master->GetTarget());
|
|
if (!vehicleBase)
|
|
return false;
|
|
Vehicle* veh = vehicleBase->GetVehicleKit();
|
|
if (vehicleBase->IsVehicle() && veh && veh->GetAvailableSeatCount())
|
|
{
|
|
return EnterVehicle(vehicleBase, false);
|
|
}
|
|
return false;
|
|
}
|
|
|
|
GuidVector npcs = AI_VALUE(GuidVector, "nearest vehicles");
|
|
for (GuidVector::iterator i = npcs.begin(); i != npcs.end(); i++)
|
|
{
|
|
Unit* vehicleBase = botAI->GetUnit(*i);
|
|
if (!vehicleBase)
|
|
continue;
|
|
|
|
if (vehicleBase->HasUnitFlag(UNIT_FLAG_NOT_SELECTABLE))
|
|
continue;
|
|
|
|
// dont let them get in the cannons as they'll stay forever and do nothing useful
|
|
// dont let them in catapult they cant use them at all
|
|
if (NPC_KEEP_CANNON == vehicleBase->GetEntry() || NPC_CATAPULT == vehicleBase->GetEntry())
|
|
continue;
|
|
|
|
if (!vehicleBase->IsFriendlyTo(bot))
|
|
continue;
|
|
|
|
if (!vehicleBase->GetVehicleKit()->GetAvailableSeatCount())
|
|
continue;
|
|
|
|
// this will avoid adding passengers (which dont really do much for the IOC vehicles which is the only place
|
|
// this code is used)
|
|
if (vehicleBase->GetVehicleKit()->IsVehicleInUse())
|
|
continue;
|
|
|
|
if (EnterVehicle(vehicleBase, true))
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool EnterVehicleAction::EnterVehicle(Unit* vehicleBase, bool moveIfFar)
|
|
{
|
|
float dist = ServerFacade::instance().GetDistance2d(bot, vehicleBase);
|
|
if (dist > 40.0f)
|
|
return false;
|
|
|
|
if (dist > INTERACTION_DISTANCE && !moveIfFar)
|
|
return false;
|
|
|
|
if (dist > INTERACTION_DISTANCE)
|
|
return MoveTo(vehicleBase);
|
|
// Use HandleSpellClick instead of Unit::EnterVehicle to handle special vehicle script (ulduar)
|
|
vehicleBase->HandleSpellClick(bot);
|
|
|
|
if (!bot->IsOnVehicle(vehicleBase))
|
|
return false;
|
|
|
|
// dismount because bots can enter vehicle on mount
|
|
WorldPacket emptyPacket;
|
|
bot->GetSession()->HandleCancelMountAuraOpcode(emptyPacket);
|
|
return true;
|
|
}
|
|
|
|
bool LeaveVehicleAction::Execute(Event event)
|
|
{
|
|
Vehicle* myVehicle = bot->GetVehicle();
|
|
if (!myVehicle)
|
|
return false;
|
|
|
|
VehicleSeatEntry const* seat = myVehicle->GetSeatForPassenger(bot);
|
|
if (!seat || !seat->CanEnterOrExit())
|
|
return false;
|
|
|
|
WorldPacket p;
|
|
bot->GetSession()->HandleRequestVehicleExit(p);
|
|
|
|
return true;
|
|
}
|