mirror of
https://github.com/mod-playerbots/mod-playerbots.git
synced 2026-02-08 05:01:09 +00:00
13fff46fa0
# Pull Request
- Applies the clean and corrected singletons, Meyer pattern. (cherry
picked from @SmashingQuasar )
Testing by just playing the game in various ways. Been tested by myself
@Celandriel and @SmashingQuasar
---
## Complexity & Impact
- Does this change add new decision branches?
- [x] No
- [ ] Yes (**explain below**)
- Does this change increase per-bot or per-tick processing?
- [x] No
- [ ] Yes (**describe and justify impact**)
- Could this logic scale poorly under load?
- [x] No
- [ ] Yes (**explain why**)
---
## Defaults & Configuration
- Does this change modify default bot behavior?
- [x] No
- [ ] Yes (**explain why**)
---
## AI Assistance
- Was AI assistance (e.g. ChatGPT or similar tools) used while working
on this change?
- [x] No
- [ ] Yes (**explain below**)
---
## Final Checklist
- [x] Stability is not compromised
- [x] Performance impact is understood, tested, and acceptable
- [x] Added logic complexity is justified and explained
- [x] Documentation updated if needed
---
## Notes for Reviewers
Anything that significantly improves realism at the cost of stability or
performance should be carefully discussed
before merging.
---------
Co-authored-by: Nicolas Lebacq <nicolas.cordier@outlook.com>
Co-authored-by: Keleborn <22352763+Celandriel@users.noreply.github.com>
67 lines
2.2 KiB
C++
67 lines
2.2 KiB
C++
/*
|
|
* Copyright (C) 2016+ AzerothCore <www.azerothcore.org>, released under GNU AGPL v3 license, you may redistribute it
|
|
* and/or modify it under version 3 of the License, or (at your option), any later version.
|
|
*/
|
|
|
|
#include "ReachTargetActions.h"
|
|
|
|
#include "Event.h"
|
|
#include "PlayerbotAIConfig.h"
|
|
#include "Playerbots.h"
|
|
#include "ServerFacade.h"
|
|
|
|
bool ReachTargetAction::Execute(Event event) { return ReachCombatTo(AI_VALUE(Unit*, GetTargetName()), distance); }
|
|
|
|
bool ReachTargetAction::isUseful()
|
|
{
|
|
// do not move while staying
|
|
if (botAI->HasStrategy("stay", botAI->GetState()))
|
|
{
|
|
return false;
|
|
}
|
|
|
|
// do not move while casting
|
|
if (bot->GetCurrentSpell(CURRENT_CHANNELED_SPELL) != nullptr)
|
|
{
|
|
return false;
|
|
}
|
|
Unit* target = GetTarget();
|
|
// float dis = distance + CONTACT_DISTANCE;
|
|
return target &&
|
|
!bot->IsWithinCombatRange(target, distance); // ServerFacade::instance().IsDistanceGreaterThan(AI_VALUE2(float,
|
|
// "distance", GetTargetName()), distance);
|
|
}
|
|
|
|
std::string const ReachTargetAction::GetTargetName() { return "current target"; }
|
|
|
|
bool CastReachTargetSpellAction::isUseful()
|
|
{
|
|
// do not move while staying
|
|
if (botAI->HasStrategy("stay", botAI->GetState()))
|
|
{
|
|
return false;
|
|
}
|
|
|
|
return ServerFacade::instance().IsDistanceGreaterThan(AI_VALUE2(float, "distance", "current target"),
|
|
(distance + sPlayerbotAIConfig.contactDistance));
|
|
}
|
|
|
|
ReachSpellAction::ReachSpellAction(PlayerbotAI* botAI)
|
|
: ReachTargetAction(botAI, "reach spell", botAI->GetRange("spell"))
|
|
{
|
|
}
|
|
|
|
ReachPartyMemberToHealAction::ReachPartyMemberToHealAction(PlayerbotAI* botAI)
|
|
: ReachTargetAction(botAI, "reach party member to heal", botAI->GetRange("heal"))
|
|
{
|
|
}
|
|
|
|
std::string const ReachPartyMemberToHealAction::GetTargetName() { return "party member to heal"; }
|
|
|
|
ReachPartyMemberToResurrectAction::ReachPartyMemberToResurrectAction(PlayerbotAI* botAI)
|
|
: ReachTargetAction(botAI, "reach party member to resurrect", botAI->GetRange("spell"))
|
|
{
|
|
}
|
|
|
|
std::string const ReachPartyMemberToResurrectAction::GetTargetName() { return "party member to resurrect"; }
|