Commit Graph

101 Commits

Author SHA1 Message Date
Andrew
6df652a8dd fix(Core/Creature): Prevent combat movement disabled creatures from r… (#18428)
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary

* fixbuild

* Apply suggestions from code review
2024-02-27 10:11:39 -03:00
Dan
a4dc083b42 fix(Scripts/Hyjal): move Hyjal boss waypoints to DB (#18299)
* put anetheron movement in wps

* move all wps to db for bosses
2024-02-12 08:17:39 -03:00
IntelligentQuantum
fa884ae385 chore(Scripts/Kalimdor): remove useless includes (#18065) 2023-12-26 06:08:37 -03:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Winfidonarleyan
e90d7a2f92 chore(Core/Misc): sort includes (#17776)
* chore(Cleanup): sort includes

* fix build

* fix build again
2023-11-18 17:51:26 +01:00
Andrew
d325332090 refactor(Scripts/OHF): Clean up script files (#17724) 2023-11-15 20:44:39 -03:00
avarishd
4cb25b4b5e fix(Scripts/DurnholdeKeep): Captain Skarloc spawning double/wrong adds (#17667)
* fix(Scripts/DurnholdeKeep): Captain Skarloc spawning double/wrong adds

* Ss

* DoForAllSummons
2023-11-14 08:53:17 +01:00
Kitzunu
bbadc32bea Revert Visibility Notifier changes (#17682)
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569)"

This reverts commit 79b39f9655.

* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)"

This reverts commit 60e27511c5.

* Revert "fix(Core): GridCleanUpDelay Log (#17436)"

This reverts commit 90b16ca065.

* Revert "feat(Core/Grids): Implement visibility notifier (#15919)"

This reverts commit 2779833768.
2023-11-12 00:48:49 +01:00
Kitzunu
f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
Francesco Borzì
eaa6487fc2 refactor(Scripts): remove unused imports (#17097) 2023-08-27 22:25:22 -03:00
Anton Popovichenko
f4658a1df2 fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries. (#17070)
* fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries.

* Fix build
2023-08-25 09:15:07 -03:00
Skjalf
80a8f6d47a fix(Scripts/OHF): Don't update the escort steps when Drake dies (#17024)
* fix(Scripts/OHF): Don't update the escort steps when Drake dies

* update gossip req

* Update rev_1692233536025387200.sql
2023-08-20 15:46:39 -03:00
Dan
8621118b83 fix(Scripts/OHF): Fix not being able to start the escort if you already killed Lt. Drake (#17006) 2023-08-14 13:05:20 -03:00
Skjalf
8dc8424f09 fix(Scripts/OHF): Killing Drake should not be required to start Thral… (#17000)
fix(Scripts/OHF): Killing Drake should not be required to start Thrall's escort
2023-08-13 13:39:08 -03:00
Johaine
f0a96b4489 fix(Scripts/EscapeFromDurnholde): Fix escort mission getting stuck (#16636)
Fix stuck event

Fix escort event possibly getting stuck by preventing
DATA_ESCORT_PROGRESS from being decreased
2023-08-02 14:52:18 -03:00
天鹿
90e23cbc66 fix(Core/Raid): Archimonde's Unable to kill (#15128)
Fix(Core);[raid]Archimonde's BUG
2023-07-27 10:33:24 -03:00
Johaine
5060407598 fix(Scripts/TheBlackMorass): rework time rift event logic (#16535)
* Fix visual crystals

This fixes the crystals not despawning on Medivh's death and being
resummoned after every reset

* Fix summoning circle visual after cleanup

Fix respawn of summoning circle visual NPC
Move respawn to same moment as Medivh respawn

* Fix race condition during script cleanup after event failure

This fixes the bug that rifts still spawn after shield is at 0%,
enabling players to exploit the instance and defeat bosses at their own
pace.

In general, removing rifts schedules spawning of new rifts

After failing the event (shield at 0%) this introduces a race between
rift despawn and (scheduler) cleanup

Fix it by introducing a check if the event has been started and should
still progress.

* Fix softlock of event during break after boss

Make sure that the delay condition is removed if event fails

Meeting certain conditions it was possible to softlock the event by
extending the after-boss-break indefinitely

* Cleanup failed instance without player interaction

This respawns Medivh and re-enables the event 5 minutes after a failure

Retrying the event shouldn't require all players to leave the instance
and to reenter

* Misc cleanups

Remove unused DataTypes

Rename variable to something more self-explanatory

Remove unnecessary checks and make scheduling of rifts more
straightforward

Fix typos
2023-06-18 11:47:27 -03:00
Eddy Vega
be622fa720 refactor(Scripts/CavernsOfTime): Mass struct/model update (#16268)
init
2023-05-28 16:30:30 -03:00
avarishd
1062977283 fix(Scripts/OldHillsbrad): Old Hillsbrad Foothills - Captain Skarloc casting wrong spell (#15486) 2023-03-20 06:05:31 -03:00
UltraNix
684bb1793d fix(Scripts): Crashfix. (#15459) 2023-03-19 16:29:57 +01:00
Skjalf
e2eb9fb82b fix(Scripts/BlackMorass): Don't pick the same rift spot in succession (#15359) 2023-03-12 13:27:39 -03:00
UltraNix
761c8dffad fix(Scripts/BlackMorass): Fixed rift mobs texts on summon. (#15339) 2023-03-12 00:21:51 -03:00
Skjalf
1155c4061f fix(Scripts/BlackMorass): Fix Aeonus not spawning, mobs spawning duri… (#15346) 2023-03-12 00:16:11 -03:00
UltraNix
c1c877060c fix(Scripts/BlackMorass): Fixed mob waves sequence. (#14863) 2023-03-11 07:46:22 -03:00
Skjalf
67d02d4f1e refactor(Scripts/BlackMorass): Move the Rift handling to the creature… (#15316) 2023-03-10 14:32:18 -03:00
Skjalf
527f462826 fix(Scripts/Blackmorass): Clean unnecessary repetitions (#15299) 2023-03-07 09:19:48 -03:00
Skjalf
ef0b20928b refactor(Scripts/Blackmorass): Rewrite Blackmorass (#15290) 2023-03-06 05:49:51 -03:00
UltraNix
321195f4f8 Scripts/OldHisbradFoothills): Improved Escape from Durnholde Keep event. (#15189) 2023-03-04 17:42:02 -03:00
UltraNix
6e7aec3b95 fix(Scripts/BlackMorass): Improved Opening the Dark portal encounter. (#14861) 2023-02-19 08:18:12 +03:30
UltraNix
c3a8d26109 fix(Scripts/OldHilsbradFoothills): Corrected spawn position and waypo… (#15099) 2023-02-19 01:22:35 -03:00
UltraNix
e8b76f2625 fix(Scripts/BlackMorass): Implemented wipe event. (#14860) 2023-02-18 14:16:53 +01:00
Kitzunu
bd6034e1a9 refactor(Core/AI): Some more refactoring prep for Comat Threat system… (#15026)
Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
2023-02-13 21:39:40 +01:00
Skjalf
0dbb8c814c refactor(Core/InstanceScript): refactored load and save methods (#14977)
Co-authored-by: joschiwald <736792+joschiwald@users.noreply.github.com>
2023-02-12 15:53:48 -03:00
Kitzunu
f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
UltraNix
48ce957597 fix(Scripts/BlackMorass): Adds should walk towards Medivh. (#14945) 2023-02-12 08:27:25 -03:00
UltraNix
f4dbb04431 fix(Scripts/BlackMorass): Fixed portal positions. (#14946) 2023-02-11 17:45:36 -03:00
UltraNix
3bd988d195 fix(Scripts/BlackMorass): Fixed amount of Medivh's Integrity shield t… (#14948) 2023-02-11 17:44:59 -03:00
Skjalf
76c9eb9159 feat(Core/AI): Implement delay option to the Talk() function (#14950) 2023-02-11 17:23:57 -03:00
UltraNix
189afd1409 fix(Scripts/Instances): Fixed text during "Opening the Dark Portal" i… (#13872)
fix(Scripts/Instances): Fixed text during "Opening the Dark Portal" on Black Morass.

Fixes #1999
2022-12-11 10:53:55 -03:00
Angelo Venturini
ad4ce0895f fix: Qaston revert (#13320)
* Revert "fix(Core/QAston): fixed shields oneshotting (#13271)"

This reverts commit e05f61d1b3.

* Revert "fix(Core): Crash (#13292)"

This reverts commit a818bcf3e2.

* Revert "fix: Crash (#13241)"

This reverts commit be423a91b5.

* delete sql

* Revert "refactor(Core/Spells): Implement QAston Proc System (#11079)"

This reverts commit cbd3fd0967.

* add sql revert

* fix sql

* remove update from world.updates
2022-10-05 21:53:20 +02:00
IntelligentQuantum
cbd3fd0967 refactor(Core/Spells): Implement QAston Proc System (#11079)
* .

* sql

* .

* .

* 1

* 2

* 3

* 4

* 5

* 6

* 7

* 8

* 9

* 10

* 11

* 12

* 13

* 14

* 15

* Update spell_item.cpp

* Update Unit.cpp

* 16

* 17

* 18

* 19

* 20

* 21

* Update Unit.cpp

* REVERT UltraNIX Commit

* 22

* 23

* .

* .

* .

* warrior

* warlock

* shaman rogue priest paladin mage

* spell item

* hunter

* druid

* dk

* war

* error style

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* .

* DOND DEL ME WAD DO DO

* error 2

* .

* .

* .

* FIX

* Update SpellInfoCorrections.cpp

* Update SpellInfoCorrections.cpp

* .

* ja genau

* Update .gitignore

* .

* .

* .,

* .

* .

* .

* .

* Update Unit.cpp
2022-10-02 19:39:34 +02:00
Maelthyr
1f472bddd3 refactor(Core/Combat): Code style and improvement of ThreatMgr (#12992) 2022-09-25 15:20:34 -03:00
Maelthyr
d928d8d96a refactor(Core/Unit): PC&NPC Immunity (#11986)
* initial

* refactor(Core/Unit): PC & NPC Immunities

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* fix builds error

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* Fix nef combat, and replace SetFlag by SetUnitFlag

* fix combat with jedoga

Co-authored-by: Treeston <treeston.nmoc@gmail.com>
2022-06-18 08:16:45 -04:00
Maelthyr
dfc6adb081 refactor(Core/Combat): DeleteThreatLists() become ClearAllThreat() (#11824)
refactor(Chore/Combat): DeleteThreatLists() become ClearAllThreat()
2022-05-23 05:51:52 -03:00
Maelthyr
c5368816fa Core/Combat: rename getThreatMgr() to GetThreatMgr() (#11758) 2022-05-18 05:36:57 -03:00
IntelligentQuantum
ab4ee71762 feat(Core/Maps): AreaBoundary (#10525)
* cherry-picked commit (2da458c56d)
2022-04-15 14:10:41 +02:00
Axel Cocat
17e143763a fix(Core/Unit): Remove some hardcoded texts (#5816) 2022-04-15 13:17:06 +02:00
Kitzunu
b41967a067 feat(Core/GameObject): Gob flag helpers (#11287) 2022-04-05 13:52:58 +02:00
Kitzunu
edb7cac19b feat(Core/Unit): NPCFlags helpers (#11286)
* cherry-pick commit (TrinityCore/TrinityCore@d611925)
Co-Authored-By: Shauren <shauren.trinity@gmail.com>
2022-04-05 13:52:42 +02:00