Benjamin Jackson
52799d76f6
refactor(Core): Add definition file for area table entries. ( #22054 )
2025-05-09 15:48:02 +02:00
Tereneckla
a8b982dca8
refactor(Core/AI) don't add currentTarget to the front of the SelectTargetList for MaxThreat/Random ( #21965 )
2025-05-05 20:17:10 +01:00
Andrew
0db39f76de
fix(Core/Creature): Creatures should skip confused targets ( #21410 )
2025-02-13 13:22:02 -03:00
Anton Popovichenko
47c524581b
fix(Core/Scripts): Fix buffer-overflow errors in scripts. ( #21419 )
2025-02-12 16:34:56 -03:00
Kitzunu
bff594c4f5
feat(Unit/Misc): HasAnyAuras() HasAllAuras() HasAuras() ( #21040 )
2024-12-26 05:51:54 -03:00
Kitzunu
ed008a8780
refactor(Core/Spells): Add helpers for HasAuraType ( #20802 )
2024-12-01 08:50:59 -03:00
Andrew
e741a9a87f
feat(Core/Scripting): Implement SetInvincibility() to prevent creatur… ( #20508 )
2024-11-11 00:22:03 -03:00
Kitzunu
386aea03ee
chore(Core/Misc): Some cleanup ( #19970 )
...
* remove weird blanks
* update if
* ) ) to ))
* missed some ) )
* now switch
* .
2024-09-21 19:34:31 +02:00
Mershl
0ac7ab03bb
fix(Scripts/UBRS): increase Drakkisath's conflagrate interval from 10s..13s to 18s..25s, avoiding near infinite CC chains ( #19806 )
...
fix(Scripts/UBRS): increase Drakkisath's conflagrate interval from 10..13s to 18s..25s, avoids infinite CC chains (conflagrate is a 10s CC)
2024-09-11 11:19:14 -03:00
Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Grimdhex
221dbd3fdb
chore(Apps/Codestyle): add new codestyle checks for pointers and range loops ( #19841 )
...
* chore(Apps/Codestyle): add new codestyle checks for pointers and range loops
* revert a typo
2024-09-03 13:02:38 -03:00
Grimdhex
643362d697
refactor(Core/Object): adds consistency in the use of type object check ( #19671 )
2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3
fix(Server): remove double blank lines at the end of several files ( #19735 )
2024-08-25 07:21:14 -03:00
Francesco Borzì
2dd53e3521
refactor(Scripts): remove unused imports ( #19503 )
2024-07-29 14:44:52 -03:00
Francesco Borzì
e8bd391505
refactor(Scripts/EasternKingdoms): remove unused imports ( #19457 )
2024-07-23 08:56:46 -03:00
Jelle Meeus
5674c23d04
fix(Scripts/BlackwingLair): Nefarian say low health and rewrite p3 ( #19405 )
...
* Nefaran says low hp and shadowflame texts, use ScheduleHealthCheckEvent
* use drakonic bone spells
* remove no longer needed _scheduler
* remove extra file
2024-07-17 08:09:38 -03:00
Kitzunu
5a4692e45a
chore(Core/Misc): #include cleanup ( #19255 )
2024-07-02 15:52:02 +02:00
Jelle Meeus
a740c252f9
refactor(Scripts/BlackrockMountain): Spell Scripts registry macros ( #19186 )
...
* boss_garr aura:spell_garr_separation_nexiety_aura
* boss_garr spell:spell_garr_frenzy
* molten_core aura:spell_mc_play_dead_aura
* boss_magmadar spell:spell_magmadar_lava_bomb
* boss_majordomo_executus spell:spell_hate_to_zero
* boss_majordomo_executus aura:spell_majordomo_separation_nexiety_aura
* boss_majordomo_executus spell:spell_summon_ragnaros
* boss_shazzrah spell:spell_shazzrah_gate_dummy
* boss_baron_geddon aura:spell_geddon_inferno_aura
* boss_baron_geddon aura:spell_geddon_armageddon_aura
* boss_razorgore spell:spell_egg_event
* instance_blackwing_lair spell:spell_bwl_shadowflame
* fixup! boss_majordomo_executus aura:spell_majordomo_separation_nexiety_aura
* fixup! boss_garr aura:spell_garr_separation_nexiety_aura
* fixup! fixup! boss_garr aura:spell_garr_separation_nexiety_aura
2024-06-27 18:03:08 +02:00
Andrew
6df652a8dd
fix(Core/Creature): Prevent combat movement disabled creatures from r… ( #18428 )
...
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary
* fixbuild
* Apply suggestions from code review
2024-02-27 10:11:39 -03:00
Nathan Handley
df33a57b78
feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass ( #18243 )
...
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-10 12:25:00 -03:00
IntelligentQuantum
6a6cefb512
chore(Scripts/EK): remove useless includes ( #18075 )
...
* chore(Scripts/Kalimdor): remove useless includes
* chore(Scripts/EK): remove useless includes
2023-12-28 16:15:16 -03:00
Winfidonarleyan
eb1ecc38a5
feat(Core/Scripting): move all script objects to separated files ( #17860 )
...
* feat(Core/Scripts): move all script objects to separated files
* Apply 5bfeabde81
* try gcc build
* again
2023-12-02 21:13:20 +01:00
Winfidonarleyan
e90d7a2f92
chore(Core/Misc): sort includes ( #17776 )
...
* chore(Cleanup): sort includes
* fix build
* fix build again
2023-11-18 17:51:26 +01:00
KJack
3d20f8902b
feat(Core/Instance): InstanceScript: create Remove functions ( #17702 )
...
InstanceScript: create `Remove` helper functions
2023-11-14 08:13:28 -03:00
Kitzunu
bbadc32bea
Revert Visibility Notifier changes ( #17682 )
...
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569 )"
This reverts commit 79b39f9655 .
* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480 )"
This reverts commit 60e27511c5 .
* Revert "fix(Core): GridCleanUpDelay Log (#17436 )"
This reverts commit 90b16ca065 .
* Revert "feat(Core/Grids): Implement visibility notifier (#15919 )"
This reverts commit 2779833768 .
2023-11-12 00:48:49 +01:00
AG
60e27511c5
fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation ( #17480 )
...
* Bug fixes
- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time
* Removed logic to set gameobject as active
- More alignement with TC.
- Reduces CPU usage drastically
* Revert back to using time_t instead of std chrono
* Invoke SetNoCreate() method to reduce CPU usage drastically
* Remove setActive from static and motion transports
* Fix performance issues
* Added SetFarVisible to WG and some dungeon scripts
- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)
* Removed comments related to VISIBILITY_COMPENSATION
* Fix log
* Deleted unused files + corrected a check
* Added missing header
* Removed unused parameter
* Removed another unsued parameter
* Changed vector to set for i_visibleNow
- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
Dan
d15d72c812
fix(Scripts/BlackwingLair): Orb of Domination can no longer be used when you are controlling a pet ( #16880 )
...
initial
2023-09-17 07:50:43 -03:00
Anton Popovichenko
f4658a1df2
fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries. ( #17070 )
...
* fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries.
* Fix build
2023-08-25 09:15:07 -03:00
Tung Bui (Leo)
da8ebbae0b
fix(Scripts/UBRS): typo in Blackrock Spire instance ( #16976 )
...
* fix(spells/scripts): typo in Blackrock Spire instance
* fix(spells/scripts): typo in Blackrock Spire instance - usage
2023-08-10 23:13:45 -03:00
KJack
a696227e8d
fix(Scripts/UBRS): Update UBRS/Pyroguard Emberseer script to fix issues and increase accuracy ( #16352 )
...
* Update UBRS/Pyroguard Emberseer script to fix issues and increase accuracy.
- Remove EVENT_PLAYER_CHECK which was causing triggering the fight to work only sporadically
- Break out pre-enter-combat phase to better emulate actual timing. Fixes DBM timing being off
- Pre-enter-combat sequence starts as soon as the adds are engaged, not after 32 seconds
- disable fire shield during pre-enter-combat to keep the fight from resetting
- remove faster add despawn which doesn't appear to be in the WotLK Classic version
- remove adds doing EVENT_ENCAGE every 10-20s, which was unneccesary and caused them to glitch move around the player
* Small change to pre-add timing.
2023-06-01 08:40:02 -03:00
天鹿
df77b5f4f7
chore(core): cleanup code p3 ( #16073 )
...
* Update MMapMgr.cpp
* Update UpdateFetcher.cpp
* Update AuctionHouseMgr.cpp
* Update AuctionHouseMgr.h
* Update BattlegroundAV.cpp
* Update ChannelMgr.cpp
* Update ThreatMgr.h
* Update Player.h
* Update PlayerSettings.cpp
* Update ObjectMgr.cpp
* Update Guild.cpp
* Update Guild.h
* Update Map.cpp
* Update World.cpp
* Update boss_nefarian.cpp
* Update boss_prince_malchezaar.cpp
* Update boss_venoxis.cpp
* Update zone_elwynn_forest.cpp
* Update zulfarrak.cpp
* Update boss_novos.cpp
2023-04-24 08:13:07 -03:00
ZhengPeiRu21
817cb2d685
fix(Scripts/MoltenCore): Correct Baron Geddon Inferno damage values ( #15637 )
...
* fix(Scripts/Molten Core): Correct Baron Geddon Inferno damage values
* Update tick counts
2023-04-02 15:35:47 -03:00
Stefano Borzì
034b521501
feat(CI): add cppcheck ( #15211 )
...
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com >
2023-03-05 18:47:18 +01:00
Kitzunu
bd6034e1a9
refactor(Core/AI): Some more refactoring prep for Comat Threat system… ( #15026 )
...
Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com >
2023-02-13 21:39:40 +01:00
Tereneckla
fdfa88093e
fix(Scripts/MoltenCore): revert ragnaros submerge event to 180s ( #15001 )
2023-02-13 14:32:42 -03:00
Skjalf
0dbb8c814c
refactor(Core/InstanceScript): refactored load and save methods ( #14977 )
...
Co-authored-by: joschiwald <736792+joschiwald@users.noreply.github.com >
2023-02-12 15:53:48 -03:00
Kitzunu
f039836a2f
chore(Core/Misc): Change all TODO to doxygen comment ( #14966 )
2023-02-12 10:05:34 -03:00
Skjalf
3106a83e8a
fix(Scripts/BlackwingLair): Fix Flamegor frenzy timer ( #14908 )
2023-02-08 17:05:09 +01:00
Angelo Venturini
5029e1240d
fix: Crash on Flamegor ( #14906 )
2023-02-08 16:57:35 +01:00
Maelthyr
afb071bb04
refactor(Scripts): Update vanilla scripts to std::chrono ( #14876 )
...
Co-authored-by: Maelthyrr <AmanThul-Project@proton.me >
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com >
2023-02-05 12:35:48 -03:00
Skjalf
bf30c66ba4
feat(Core/GameObject): Expand IsSummonedBy() to GameObjects ( #14789 )
...
Co-authored-by: jackpoz <giacomopoz@gmail.com >
2023-01-29 09:44:33 -03:00
Skjalf
b4e3f1310b
feat(Core/Unit): Add KillSelf overload ( #14785 )
...
Co-authored-by: jackpoz <giacomopoz@gmail.com >
2023-01-28 17:57:23 -03:00
Kitzunu
4870b14b1f
refactor(Core/Object): getLevel() -> GetLevel() ( #14122 )
...
* refactor(Core/Object): getLevel() -> GetLevel()
* fix build and sneak some doxygen in
* codeSTLE
* codestyle
2022-12-31 17:39:23 +01:00
UltraNix
08ff2f277b
fix(Scripts/BlackwingLair): Razorgore the Untamed should not reset enco… ( #13782 )
...
* fix(Raids/BlackwingLair): Razorgore the Untamed should not reset encounter upon casting Conflagrate when soloing.
Fixes #13761
* Update.
2022-12-06 09:47:08 -03:00
Maelthyr
3024bee3ba
refactor(Core/UnitAI): Update target selector ( #13169 )
...
* refactor(Core/UnitAI): Update TargetSelector.
Cherry-pick:
*https://github.com/TrinityCore/TrinityCore/pull/19930
Co-authored-by: Treeston <treeston@users.noreply.github.com >
* fix GGC/CLang errors in scripts
* .
* missing a file and fix a script error
* .
* fix path changes dude to a miss click in the second commit
* .
Co-authored-by: Maelthyrr <lynethris@protonmail.ch >
Co-authored-by: Treeston <treeston@users.noreply.github.com >
2022-12-06 09:27:13 -03:00
Maelthyr
c1c9dc6105
refactor(Core/ScriptedAI): few improvements with threat methods ( #13146 )
...
improve threat scripts
Co-authored-by: Maelthyrr <lynethris@protonmail.ch >
2022-11-12 13:29:28 +01:00
UltraNix
751bc4ffe1
fix(Scripts/MoltenCore): Lava Spawn. ( #13508 )
...
Fixes #13107
2022-10-29 07:14:38 -03:00
UltraNix
49ee806584
fix(Scripts/MoltenCore): Added loot recipient to Cache of the Firelord. ( #13209 )
2022-10-08 13:28:30 -03:00
UltraNix
6c3fc2603b
fix(Scripts/MoltenCore): Players should not be able to summon Ragnaro… ( #13128 )
...
fix(Scripts/MoltenCore): Players should not be able to summon Ragnaros before Majordomo's teleport.
Fixes #11870
2022-09-26 09:41:20 -04:00
Maelthyr
1f472bddd3
refactor(Core/Combat): Code style and improvement of ThreatMgr ( #12992 )
2022-09-25 15:20:34 -03:00