UltraNix
3fee40be7d
fix(Core/Creatures): Spells casted by player should tap the creature … ( #14725 )
...
…only if in combat with it.
2023-01-26 04:38:16 -03:00
UltraNix
ff8374ac98
fix(DB/SAI): Caretaker Smither. ( #14445 )
...
Fixes #14384
Author: @Gultask
<!-- First of all, THANK YOU for your contribution. -->
## Issues Addressed:
<!-- If your fix has a relating issue, link it below -->
- Closes #14384
## Tests Performed:
<!-- Does it build without errors? Did you test in-game? What did you
test? On which OS did you test? Describe any other tests performed -->
- Tested ingame.
## How to Test the Changes:
<!-- Describe in a detailed step-by-step order how to test the changes
-->
`.go c id 20363`
<!-- If you intend to contribute repeatedly to our project, it is a good
idea to join our discord channel. We set ranks for our contributors and
give them access to special resources or knowledge:
https://discord.com/invite/DasJqPba )
Do not remove the instructions below about testing, they will help users
to test your PR -->
## How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as **[WAITING TO BE
TESTED]**.
You can help by testing PRs and writing your feedback here on the PR's
page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
**REMEMBER**: when testing a PR that changes something **generic** (i.e.
a part of code that handles more than one specific thing), the tester
should not only check that the PR does its job (e.g. fixing spell XXX)
but **especially** check that the PR does not cause any regression (i.e.
introducing new bugs).
**For example**: if a PR fixes spell X by changing a part of code that
handles spells X, Y, and Z, we should not only test X, but **we should
test Y and Z as well**.
Co-authored-by: Gultask <gultask@gmail.com >
2023-01-25 17:00:19 -03:00
M'Dic
437d93926f
fix (core): macos12 depreciation workflow error / security CWE-120 ( #14746 )
...
* fix (core): macos12 depreciation workflow error
Fix workflow error message:
azerothcore-wotlk/src/common/Utilities/Util.cpp:558:9: fatal error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
sprintf(buffer, "%02X", bytes[i]);
* Update BattlegroundAV.cpp
* more macos12 fixit
* Update spell_generic.cpp
2023-01-23 06:13:27 -05:00
UltraNix
8cb88cce52
fix(Scripts/The Underbog): Rewritten The Black Stalker's Levitate mec… ( #14541 )
...
* fix(Scripts/The Underbog): Rewritten The Black Stalker's Levitate mechanic.
Fixes #13988
* buildfix.
* Update src/server/scripts/Outland/CoilfangReservoir/underbog/boss_the_black_stalker.cpp
Co-authored-by: offl <offl@gmail.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2023-01-07 20:28:22 +01:00
Kitzunu
7b774c8141
fix(Core/Spell): Roll 'dem Bones ( #14522 )
...
* fix(Core/Spell): Roll 'dem Bones
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14357
* Partial cp of 029527365f
Co-Authored-By: joschiwald <736792+joschiwald@users.noreply.github.com >
* newline pleb
Co-authored-by: joschiwald <736792+joschiwald@users.noreply.github.com >
2023-01-07 20:05:42 +01:00
Gultask
6b4ef50e7a
Revert "fix(Core/Spells): Ignite and Revitalize should not prelong co… ( #14513 )
...
Revert "fix(Core/Spells): Ignite and Revitalize should not prelong combat. (#13812 )"
This reverts commit 96fa9c5c7b .
2023-01-05 23:14:56 -03:00
UltraNix
c3b8df8cb2
fix(Core/Spells): Aura with SPELL_AURA_MOD_FEAR effect are always c… ( #14450 )
...
fix(Core/Spells): Aura with `SPELL_AURA_MOD_FEAR` effect are always considered as negative.
Fixes #14297
2023-01-06 00:53:37 +01:00
UltraNix
7a03130b94
fix(Core/Spells): Regen auras should not be removed by Rapid Recupera… ( #14269 )
...
fix(Core/Spells): Regen auras should not be removed by Rapid Recuperation.
Fixes #14263
2023-01-06 00:53:10 +01:00
UltraNix
14f3b444ae
fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SU… ( #14054 )
...
* fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SUMMONER` summon flag.
Fixes #6674
* Update.
2023-01-06 00:52:05 +01:00
UltraNix
0e1e8f27de
fix(Core/Spells): Every spell casted by player should tap the creature. ( #14037 )
...
Fixes #11888
2023-01-06 00:51:54 +01:00
UltraNix
96fa9c5c7b
fix(Core/Spells): Ignite and Revitalize should not prelong combat. ( #13812 )
...
Fixes #13330
2023-01-06 00:50:53 +01:00
Angelo Venturini
9e18b86311
fix(Core/Auras): SPELL_AURA_MOD_SCALE should scale additively instead… ( #14425 )
...
...multiplicatively
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2023-01-02 20:43:20 -03:00
UltraNix
8448996639
fix(Core/Spells): Fixed Hunter's Mark not being casted by Swamplord M… ( #14457 )
...
fix(Core/Spells): Fixed Hunter's Mark not being casted by Swamplord Musel'ek.
Fixes #13993
2023-01-01 08:49:47 -03:00
Kitzunu
4870b14b1f
refactor(Core/Object): getLevel() -> GetLevel() ( #14122 )
...
* refactor(Core/Object): getLevel() -> GetLevel()
* fix build and sneak some doxygen in
* codeSTLE
* codestyle
2022-12-31 17:39:23 +01:00
Skjalf
a73d4173df
feat(Core/Scripting): Pass SpellInfo through the ModifyPeriodicDamage… ( #14360 )
...
feat(Core/Scripting): Pass SpellInfo through the ModifyPeriodicDamageAurasTick() hook
2022-12-24 11:38:21 -03:00
UltraNix
3fc22f2ff9
fix(Core/Spells): Cursed Cauldron gobs despawn after 5 seconds. ( #14252 )
...
Fixes #14241
2022-12-22 03:40:38 -03:00
Angelo Venturini
4992940453
fix(Core/Auras): Implement Roc form ( #13959 )
...
Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com >
Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com >
2022-12-11 10:58:20 -03:00
UltraNix
975fd8782f
fix(DB/SAI): Fixed spam chat made by Coilfang Slavemaster and Coilfan… ( #13871 )
...
fix(DB/SAI): Fixed spam chat made by Coilfang Slavemaster and Coilfang Slavehandler scripts.
Fixes #1888
2022-12-06 09:41:45 -03:00
UltraNix
e6aef88aba
fix(DB/Spells): Drums of War/Battle/Speed/Restorarion should apply Ti… ( #13866 )
...
...nnitus debuff.
2022-11-21 19:08:28 -03:00
UltraNix
3603f44dad
fix(Core/Spells): FIxed calculating LoS for dynamic objects. ( #13795 )
...
Fixes #13777
2022-11-16 01:19:29 -03:00
Gultask
ff5983cb16
fix(Spells/TempleOfAhnQiraj): Attempt to partly fix Digestive Acid not being applied ( #13751 )
...
* Update SpellInfoCorrections.cpp
* Update SpellInfoCorrections.cpp
* Update SpellInfoCorrections.cpp
* Update SpellInfoCorrections.cpp
2022-11-09 05:40:34 -03:00
Skjalf
ab3548e2e4
feat(Core/Scripting): Expand ModifyHealReceived() to also include hea… ( #13655 )
...
feat(Core/Scripting): Expand ModifyHealReceived() to also include healing over time
2022-11-02 19:19:17 -03:00
ZhengPeiRu21
5a7822282f
feat(Core): Config to disable all Wintergrasp processing ( #13086 )
...
* feat(Core): Config to disable all Wintergrasp processing
* Use 2 instead of -1 - configs are parsed as uint
* Fix build warnings
2022-11-01 06:22:09 -03:00
UltraNix
eb3f80ceff
fix(Core/Spells): Implemented SPELL_HIT_TYPE_SPLIT hit type. Source: … ( #13518 )
...
fix(Core/Spells): Implemented SPELL_HIT_TYPE_SPLIT hit type. Source: TrinityCore.
Fixes #13306
2022-10-29 07:13:36 -03:00
UltraNix
4ef1010f37
fix(Core/Spells): Maelstrom Weapon should not reset attack timers. ( #13504 )
...
Fixes #13179
2022-10-29 07:13:09 -03:00
UltraNix
0cd6319cfc
fix(Core/Spells): Fixed calculating LoS for dynamic objects. ( #13521 )
...
Fixes #13255
2022-10-29 07:12:49 -03:00
Gultask
003f574bf4
fix(Scripts/TempleOfAhnQiraj): Properly prevent Uppercut from triggering Double Attack ( #13581 )
...
* netherstorm&shadowmoon
* 1
* fix
* 2
2022-10-28 19:37:04 -03:00
M'Dic
55a5684c87
Add (core): Effect Transmit Anticheat Helper ( #13447 )
...
Add (core): Anticheat Helper
2022-10-23 09:19:35 -04:00
Angelo Venturini
96ff759953
fix(Scripts/TempleOfAhnQiraj): Change spawn mode for Spawn of Fankriss ( #13408 )
2022-10-14 16:28:03 -03:00
Angelo Venturini
f6b8840e34
refactor: rename spell_proc fields ( #13334 )
...
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2022-10-13 14:04:55 -03:00
M'Dic
2e6f6e26da
Add (core\db): Support for Homebind Orientation ( #13389 )
...
Add (core\db) Support for Homebind Orientation
2022-10-12 14:39:02 -04:00
UltraNix
e390087efd
feat(Core/Items): Implemented elemental weapon damage. Source: Trinit… ( #13050 )
...
...yCore.
2022-10-08 14:34:52 -03:00
UltraNix
78a383f4f7
fix(Core/Spells): Rental Racing Ram will not be removed upon entering… ( #13192 )
...
...water.
2022-10-05 21:35:46 -03:00
Angelo Venturini
ad4ce0895f
fix: Qaston revert ( #13320 )
...
* Revert "fix(Core/QAston): fixed shields oneshotting (#13271 )"
This reverts commit e05f61d1b3 .
* Revert "fix(Core): Crash (#13292 )"
This reverts commit a818bcf3e2 .
* Revert "fix: Crash (#13241 )"
This reverts commit be423a91b5 .
* delete sql
* Revert "refactor(Core/Spells): Implement QAston Proc System (#11079 )"
This reverts commit cbd3fd0967 .
* add sql revert
* fix sql
* remove update from world.updates
2022-10-05 21:53:20 +02:00
Angelo Venturini
e05f61d1b3
fix(Core/QAston): fixed shields oneshotting ( #13271 )
...
* fix(Core/QAston): fixed shields oneshotting
* fix build
2022-10-04 19:37:48 +02:00
Angelo Venturini
be423a91b5
fix: Crash ( #13241 )
2022-10-03 16:14:43 -03:00
Angelo Venturini
590525b86c
fix: Crash ( #13230 )
2022-10-02 22:35:45 -03:00
IntelligentQuantum
cbd3fd0967
refactor(Core/Spells): Implement QAston Proc System ( #11079 )
...
* .
* sql
* .
* .
* 1
* 2
* 3
* 4
* 5
* 6
* 7
* 8
* 9
* 10
* 11
* 12
* 13
* 14
* 15
* Update spell_item.cpp
* Update Unit.cpp
* 16
* 17
* 18
* 19
* 20
* 21
* Update Unit.cpp
* REVERT UltraNIX Commit
* 22
* 23
* .
* .
* .
* warrior
* warlock
* shaman rogue priest paladin mage
* spell item
* hunter
* druid
* dk
* war
* error style
* Update rev_1647677899565690722.sql
* Update rev_1647677899565690722.sql
* Update rev_1647677899565690722.sql
* .
* DOND DEL ME WAD DO DO
* error 2
* .
* .
* .
* FIX
* Update SpellInfoCorrections.cpp
* Update SpellInfoCorrections.cpp
* .
* ja genau
* Update .gitignore
* .
* .
* .,
* .
* .
* .
* .
* Update Unit.cpp
2022-10-02 19:39:34 +02:00
SoglaHash
fa00250323
fix(CORE/Spells): Fix Scaling of some Guardians ( #12625 )
...
* fix(CORE/Spells): Fix Scaling of some Guardians
Guardians summoned by engineering and items have wrong scaling.
This will fix Engineering items having the wrong stat scaling.
Also fix some Guardians summoned by items to have appropriate level and
stats.
Closes AzerothCore issue #12446
* Fix whitespace
* fix codestyle
2022-10-01 22:35:09 +02:00
M'Dic
967f8ce6d6
update (core): Startup console capitalizations ( #13195 )
2022-10-01 13:09:34 -04:00
M'Dic
33fcab0917
fix (core): Log correction ( #13181 )
...
fix (core): Commit LOG correction
2022-10-01 09:45:29 -04:00
M'Dic
ed68d1bffa
fix (Core/Spell): Shadowform Dispel ( #13155 )
2022-09-28 12:13:46 -04:00
Angelo Venturini
47f9f4917a
fix(Core/Item): Renataki's Charm of Beasts ( #13124 )
2022-09-28 00:22:08 -03:00
Maelthyr
1f472bddd3
refactor(Core/Combat): Code style and improvement of ThreatMgr ( #12992 )
2022-09-25 15:20:34 -03:00
Grimgravy
7400338ecb
fix(core/quest): improved egg collection ( #12640 )
...
* fix(core/quest): improved egg collection
* .
* Update rev_1659836460796753400.sql
* update
2022-09-25 10:46:24 -03:00
UltraNix
f658c8ea0c
fix(Core/Spells): Fingers of Frost should always proc alongside with … ( #13008 )
...
...Frostbite.
2022-09-19 00:52:37 -03:00
UltraNix
a5ab96c79d
fix(Scripts/Spells): Finger of Frost Shatter Combo. ( #13006 )
2022-09-19 00:46:17 -03:00
SoglaHash
3dde9d904c
fix(Core/Spell): Mixology duration Gift of Arthas ( #12982 )
...
Gift of Arthas duration with Mixology should be increased to 1 hour
Closes https://github.com/azerothcore/azerothcore-wotlk/issues/12941
2022-09-18 00:05:43 +02:00
ZhengPeiRu21
1ddd884d6a
feat(Core): Implement SP Bonus Coefficients from DBC ( #12562 )
...
* cherry-pick commit (1826437c09 )
* Co-authored by: ariel- <ariel-@users.noreply.github.com >
* feat(Core): Implement SP Bonus Coefficients from DBC
* Several coefficient corrections
* Fix spell_dru_lifebloom
2022-09-17 11:09:04 +02:00
UltraNix
577a0a1f3e
fix(Core/Spells): Improved Blink in WSG near NE huts. ( #13012 )
2022-09-13 22:54:05 -03:00