feat(Cmake): Rewrite build and use inherited dependencies (#1652)

2026-02-14 07:53:44 +00:00 · 2019-04-02 03:41:08 +07:00
parent 0f174eff01
commit eae9affec9
48 changed files with 6336 additions and 1178 deletions
--- a/src/cmake/macros/AutoCollect.cmake
+++ b/src/cmake/macros/AutoCollect.cmake
@@ -0,0 +1,72 @@
+# Copyright (C) 2008-2019 TrinityCore <https://www.trinitycore.org/>
+# Copyright (C) 2016+     AzerothCore <www.azerothcore.org>, released under GNU AGPL3 v3 license: https://github.com/azerothcore/azerothcore-wotlk/blob/master/LICENSE-AGPL3
+#
+# This file is free software; as a special exception the author gives
+# unlimited permission to copy and/or distribute it, with or without
+# modifications, as long as this notice is preserved.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY, to the extent permitted by law; without even the
+# implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+
+# Collects all source files into the given variable,
+# which is useful to include all sources in subdirectories.
+# Ignores full qualified directories listed in the variadic arguments.
+#
+# Use it like:
+# CollectSourceFiles(
+#   ${CMAKE_CURRENT_SOURCE_DIR}
+#   COMMON_PRIVATE_SOURCES
+#   # Exclude
+#   ${CMAKE_CURRENT_SOURCE_DIR}/PrecompiledHeaders
+#   ${CMAKE_CURRENT_SOURCE_DIR}/Platform)
+#
+function(CollectSourceFiles current_dir variable)
+  list(FIND ARGN "${current_dir}" IS_EXCLUDED)
+  if(IS_EXCLUDED EQUAL -1)
+    file(GLOB COLLECTED_SOURCES
+      ${current_dir}/*.c
+      ${current_dir}/*.cc
+      ${current_dir}/*.cpp
+      ${current_dir}/*.inl
+      ${current_dir}/*.def
+      ${current_dir}/*.h
+      ${current_dir}/*.hh
+      ${current_dir}/*.hpp)
+    list(APPEND ${variable} ${COLLECTED_SOURCES})
+
+    file(GLOB SUB_DIRECTORIES ${current_dir}/*)
+    foreach(SUB_DIRECTORY ${SUB_DIRECTORIES})
+      if (IS_DIRECTORY ${SUB_DIRECTORY})
+        CollectSourceFiles("${SUB_DIRECTORY}" "${variable}" "${ARGN}")
+      endif()
+    endforeach()
+    set(${variable} ${${variable}} PARENT_SCOPE)
+  endif()
+endfunction()
+
+# Collects all subdirectoroies into the given variable,
+# which is useful to include all subdirectories.
+# Ignores full qualified directories listed in the variadic arguments.
+#
+# Use it like:
+# CollectIncludeDirectories(
+#   ${CMAKE_CURRENT_SOURCE_DIR}
+#   COMMON_PUBLIC_INCLUDES
+#   # Exclude
+#   ${CMAKE_CURRENT_SOURCE_DIR}/PrecompiledHeaders
+#   ${CMAKE_CURRENT_SOURCE_DIR}/Platform)
+#
+function(CollectIncludeDirectories current_dir variable)
+  list(FIND ARGN "${current_dir}" IS_EXCLUDED)
+  if(IS_EXCLUDED EQUAL -1)
+    list(APPEND ${variable} ${current_dir})
+    file(GLOB SUB_DIRECTORIES ${current_dir}/*)
+    foreach(SUB_DIRECTORY ${SUB_DIRECTORIES})
+      if (IS_DIRECTORY ${SUB_DIRECTORY})
+        CollectIncludeDirectories("${SUB_DIRECTORY}" "${variable}" "${ARGN}")
+      endif()
+    endforeach()
+    set(${variable} ${${variable}} PARENT_SCOPE)
+  endif()
+endfunction()
--- a/src/cmake/macros/FindPCHSupport.cmake
+++ b/src/cmake/macros/FindPCHSupport.cmake
@@ -1,104 +1,27 @@
-FUNCTION(GET_COMMON_PCH_PARAMS PCH_HEADER PCH_FE INCLUDE_PREFIX)
-  GET_FILENAME_COMPONENT(PCH_HEADER_N ${PCH_HEADER} NAME)
-  GET_DIRECTORY_PROPERTY(TARGET_INCLUDES INCLUDE_DIRECTORIES)
+if (MSVC)
+  # Specify the maximum PreCompiled Header memory allocation limit
+  # Fixes a compiler-problem when using PCH - the /Ym flag is adjusted by the compiler in MSVC2012,
+  # hence we need to set an upper limit with /Zm to avoid discrepancies)
+  # (And yes, this is a verified, unresolved bug with MSVC... *sigh*)
+  #
+  # Note: This workaround was verified to be required on MSVC 2017 as well
+  set(COTIRE_PCH_MEMORY_SCALING_FACTOR 500)
+endif()

-  FOREACH(ITEM ${TARGET_INCLUDES})
-    LIST(APPEND INCLUDE_FLAGS_LIST "${INCLUDE_PREFIX}\"${ITEM}\" ")
-  ENDFOREACH(ITEM)
+include(cotire)

-  SET(PCH_HEADER_NAME ${PCH_HEADER_N} PARENT_SCOPE)
-  SET(PCH_HEADER_OUT ${CMAKE_CURRENT_BINARY_DIR}/${PCH_HEADER_N}.${PCH_FE} PARENT_SCOPE)
-  SET(INCLUDE_FLAGS ${INCLUDE_FLAGS_LIST} PARENT_SCOPE)
-ENDFUNCTION(GET_COMMON_PCH_PARAMS)
+function(ADD_CXX_PCH TARGET_NAME_LIST PCH_HEADER)
+  # Use the header for every target
+  foreach(TARGET_NAME ${TARGET_NAME_LIST})
+    # Disable unity builds
+    set_target_properties(${TARGET_NAME} PROPERTIES COTIRE_ADD_UNITY_BUILD OFF)

-FUNCTION(GENERATE_CXX_PCH_COMMAND TARGET_NAME INCLUDE_FLAGS IN PCH_SRC OUT)
-  IF (CMAKE_BUILD_TYPE)
-    STRING(TOUPPER _${CMAKE_BUILD_TYPE} CURRENT_BUILD_TYPE)
-  ENDIF ()
+    # Set the prefix header
+    set_target_properties(${TARGET_NAME} PROPERTIES COTIRE_CXX_PREFIX_HEADER_INIT ${PCH_HEADER})

-  SET(COMPILE_FLAGS ${CMAKE_CXX_FLAGS${CURRENT_BUILD_TYPE}})
-  LIST(APPEND COMPILE_FLAGS ${CMAKE_CXX_FLAGS})
+    # Workaround for cotire bug: https://github.com/sakra/cotire/issues/138
+    set_property(TARGET ${TARGET_NAME} PROPERTY CXX_STANDARD 14)
+  endforeach()

-  IF ("${CMAKE_SYSTEM_NAME}" MATCHES "Darwin")
-    IF (NOT "${CMAKE_OSX_ARCHITECTURES}" STREQUAL "")
-      LIST(APPEND COMPILE_FLAGS "-arch ${CMAKE_OSX_ARCHITECTURES}")
-    ENDIF ()
-    IF (NOT "${CMAKE_OSX_SYSROOT}" STREQUAL "")
-      LIST(APPEND COMPILE_FLAGS "-isysroot ${CMAKE_OSX_SYSROOT}")
-    ENDIF ()
-    IF (NOT "${CMAKE_OSX_DEPLOYMENT_TARGET}" STREQUAL "")
-      LIST(APPEND COMPILE_FLAGS "-mmacosx-version-min=${CMAKE_OSX_DEPLOYMENT_TARGET}")
-    ENDIF ()
-  ENDIF ()
-
-  GET_DIRECTORY_PROPERTY(TARGET_DEFINITIONS COMPILE_DEFINITIONS)
-  FOREACH(ITEM ${TARGET_DEFINITIONS})
-    LIST(APPEND DEFINITION_FLAGS "-D${ITEM} ")
-  ENDFOREACH(ITEM)
-
-  SEPARATE_ARGUMENTS(COMPILE_FLAGS)
-  SEPARATE_ARGUMENTS(INCLUDE_FLAGS)
-  SEPARATE_ARGUMENTS(DEFINITION_FLAGS)
-
-  GET_FILENAME_COMPONENT(PCH_SRC_N ${PCH_SRC} NAME)
-  ADD_LIBRARY(${PCH_SRC_N}_dephelp MODULE ${PCH_SRC})
-
-  ADD_CUSTOM_COMMAND(
-    OUTPUT ${OUT}
-    COMMAND ${CMAKE_CXX_COMPILER}
-    ARGS ${DEFINITION_FLAGS} ${COMPILE_FLAGS} ${INCLUDE_FLAGS} -x c++-header ${IN} -o ${OUT}
-    DEPENDS ${IN} ${PCH_SRC_N}_dephelp
-    WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
-  )
-
-  ADD_CUSTOM_TARGET(generate_${PCH_SRC_N}
-    DEPENDS ${OUT}
-  )
-
-  ADD_DEPENDENCIES(${TARGET_NAME} generate_${PCH_SRC_N})
-ENDFUNCTION(GENERATE_CXX_PCH_COMMAND)
-
-FUNCTION(ADD_CXX_PCH_GCC TARGET_NAME PCH_HEADER PCH_SOURCE)
-  GET_COMMON_PCH_PARAMS(${PCH_HEADER} "gch" "-I")
-  GENERATE_CXX_PCH_COMMAND(${TARGET_NAME} "${INCLUDE_FLAGS}" ${PCH_HEADER} ${PCH_SOURCE} ${PCH_HEADER_OUT})
-  SET_TARGET_PROPERTIES(
-    ${TARGET_NAME} PROPERTIES
-    COMPILE_FLAGS "-include ${CMAKE_CURRENT_BINARY_DIR}/${PCH_HEADER_NAME}"
-  )
-ENDFUNCTION(ADD_CXX_PCH_GCC)
-
-FUNCTION(ADD_CXX_PCH_CLANG TARGET_NAME PCH_HEADER PCH_SOURCE)
-  GET_COMMON_PCH_PARAMS(${PCH_HEADER} "pch" "-I")
-  GENERATE_CXX_PCH_COMMAND(${TARGET_NAME} "${INCLUDE_FLAGS}" ${PCH_HEADER} ${PCH_SOURCE} ${PCH_HEADER_OUT})
-  SET_TARGET_PROPERTIES(
-    ${TARGET_NAME} PROPERTIES
-    COMPILE_FLAGS "-include-pch ${PCH_HEADER_OUT}"
-  )
-ENDFUNCTION(ADD_CXX_PCH_CLANG)
-
-FUNCTION(ADD_CXX_PCH_MSVC TARGET_NAME PCH_HEADER PCH_SOURCE)
-  GET_COMMON_PCH_PARAMS(${PCH_HEADER} "pch" "/I")
-  SET_TARGET_PROPERTIES(
-    ${TARGET_NAME} PROPERTIES
-    COMPILE_FLAGS "/FI${PCH_HEADER_NAME} /Yu${PCH_HEADER_NAME}"
-  )
-  SET_SOURCE_FILES_PROPERTIES(
-    ${PCH_SOURCE} PROPERTIES
-    COMPILE_FLAGS "/Yc${PCH_HEADER_NAME}"
-  )
-ENDFUNCTION(ADD_CXX_PCH_MSVC)
-
-FUNCTION(ADD_CXX_PCH TARGET_NAME PCH_HEADER PCH_SOURCE)
-  IF (MSVC)
-    ADD_CXX_PCH_MSVC(${TARGET_NAME} ${PCH_HEADER} ${PCH_SOURCE})
-  ELSEIF ("${CMAKE_GENERATOR}" MATCHES "Xcode")
-    SET_TARGET_PROPERTIES(${TARGET_NAME} PROPERTIES
-      XCODE_ATTRIBUTE_GCC_PRECOMPILE_PREFIX_HEADER YES
-      XCODE_ATTRIBUTE_GCC_PREFIX_HEADER "${CMAKE_CURRENT_SOURCE_DIR}/${PCH_HEADER}"
-    )
-  ELSEIF ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
-    ADD_CXX_PCH_CLANG(${TARGET_NAME} ${PCH_HEADER} ${PCH_SOURCE})
-  ELSEIF ("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU")
-    ADD_CXX_PCH_GCC(${TARGET_NAME} ${PCH_HEADER} ${PCH_SOURCE})
-  ENDIF ()
-ENDFUNCTION(ADD_CXX_PCH)
+  cotire(${TARGET_NAME_LIST})
+endfunction(ADD_CXX_PCH)
--- a/src/cmake/macros/FindReadline.cmake
+++ b/src/cmake/macros/FindReadline.cmake
@@ -1,18 +0,0 @@
-# find Readline (terminal input library) includes and library
-#
-# READLINE_INCLUDE_DIR - where the directory containing the READLINE headers can be found
-# READLINE_LIBRARY     - full path to the READLINE library
-# READLINE_FOUND       - TRUE if READLINE was found
-
-FIND_PATH(READLINE_INCLUDE_DIR readline/readline.h)
-FIND_LIBRARY(READLINE_LIBRARY NAMES readline) 
-
-IF (READLINE_INCLUDE_DIR AND READLINE_LIBRARY)
-    SET(READLINE_FOUND TRUE)
-    MESSAGE(STATUS "Found Readline library: ${READLINE_LIBRARY}")
-    MESSAGE(STATUS "Include dir is: ${READLINE_INCLUDE_DIR}")
-    INCLUDE_DIRECTORIES(${READLINE_INCLUDE_DIR})
-ELSE (READLINE_INCLUDE_DIR AND READLINE_LIBRARY)
-    SET(READLINE_FOUND FALSE)
-    MESSAGE(FATAL_ERROR "** Readline library not found!\n** Your distro may provide a binary for Readline e.g. for ubuntu try apt-get install libreadline5-dev")
-ENDIF (READLINE_INCLUDE_DIR AND READLINE_LIBRARY)
--- a/src/cmake/platform/win/settings.cmake
+++ b/src/cmake/platform/win/settings.cmake
@@ -4,8 +4,6 @@ option(USE_MYSQL_SOURCES "Use included MySQL-sources to build libraries" 0)
 # Package overloads
 set(ACE_INCLUDE_DIR ${CMAKE_SOURCE_DIR}/deps/acelite)
 set(ACE_LIBRARY "ace")
-set(BZIP2_LIBRARIES "bzip2")
-set(ZLIB_LIBRARIES "zlib")

 if( USE_MYSQL_SOURCES )
  set(MYSQL_INCLUDE_DIR ${CMAKE_SOURCE_DIR}/deps/mysqllite/include)