nchebrov/azerothcore-wotlk
1
0
Fork 0
mirror of https://github.com/mod-playerbots/azerothcore-wotlk.git synced 2026-03-15 05:25:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Core/Pet): Fix possible heap-use-after-free of charmInfo when handling pet action. (#21439)

Browse Source
This commit is contained in:
Anton Popovichenko
2025-02-14 20:02:02 +01:00
committed by GitHub
parent 75441ddb3b
commit cdcdf4564b
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/server/game/Handlers/PetHandler.cpp
View File

@@ -432,8 +432,14 @@ void WorldSession::HandlePetActionHelper(Unit* pet, ObjectGuid guid1, uint32 spe
spell->prepare(&(spell->m_targets)); spell->prepare(&(spell->m_targets));
charmInfo->SetForcedSpell(0); // spell->prepare() can delete charm info.
charmInfo->SetForcedTargetGUID(); // Let's refresh the pointer.
charmInfo = pet->GetCharmInfo();
if (charmInfo)
{
charmInfo->SetForcedSpell(0);
charmInfo->SetForcedTargetGUID();
}
} }
else if (pet->ToPet() && (result == SPELL_FAILED_LINE_OF_SIGHT || result == SPELL_FAILED_OUT_OF_RANGE)) else if (pet->ToPet() && (result == SPELL_FAILED_LINE_OF_SIGHT || result == SPELL_FAILED_OUT_OF_RANGE))
{ {