refactor(Core/Misc): rename some variables that can be confusing (#10592)

This commit is contained in:
Kitzunu
2022-02-14 20:06:59 +01:00
committed by GitHub
parent 455899dc75
commit 665919d010
4 changed files with 25 additions and 25 deletions

View File

@@ -477,13 +477,13 @@ public:
//set tempfaction for creature
static bool HandleNpcSetFactionTempIdCommand(ChatHandler* handler, uint32 tempfaction)
{
Player* me = handler->GetSession()->GetPlayer();
Unit* SelectedCreature = me->GetSelectedUnit();
Player* player = handler->GetSession()->GetPlayer();
Unit* unit = player->GetSelectedUnit();
if (!SelectedCreature)
if (!unit)
return false;
Creature* creature = SelectedCreature->ToCreature();
Creature* creature = unit->ToCreature();
if (!creature)
return false;
@@ -496,12 +496,12 @@ public:
//set orginal faction for npc
static bool HandleNpcSetOriginalFaction(ChatHandler* handler)
{
Player* me = handler->GetSession()->GetPlayer();
Player* player = handler->GetSession()->GetPlayer();
if (!me)
if (!player)
return false;
Creature* creature = me->GetSelectedUnit()->ToCreature();
Creature* creature = player->GetSelectedUnit()->ToCreature();
if (!creature)
return false;

View File

@@ -895,15 +895,15 @@ public:
{
if (Unit* target = GetTarget())
if (target->GetDisplayId() != 11686)
if (Creature* me = target->ToCreature())
if (Player* p = me->SelectNearestPlayer(2.75f))
if (me->GetExactDist2d(p) <= 2.75f)
if (Creature* creature = target->ToCreature())
if (Player* player = creature->SelectNearestPlayer(2.75f))
if (creature->GetExactDist2d(player) <= 2.75f)
{
me->AI()->DoAction(1); // despawning = true;
me->GetMotionMaster()->MoveIdle();
me->CastSpell((Unit*)nullptr, me->GetEntry() == NPC_CONCENTRATED_LIGHT ? SPELL_UNLEASHED_LIGHT : SPELL_UNLEASHED_DARK, false);
me->SetDisplayId(11686);
me->DespawnOrUnsummon(1500);
creature->AI()->DoAction(1); // despawning = true;
creature->GetMotionMaster()->MoveIdle();
creature->CastSpell((Unit*)nullptr, creature->GetEntry() == NPC_CONCENTRATED_LIGHT ? SPELL_UNLEASHED_LIGHT : SPELL_UNLEASHED_DARK, false);
creature->SetDisplayId(11686);
creature->DespawnOrUnsummon(1500);
}
}