From 4fb0464b60a4d8ab1ce739cce2e1afada03bac61 Mon Sep 17 00:00:00 2001
From: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Date: Sun, 3 Dec 2023 13:38:51 +0100
Subject: [PATCH] =?UTF-8?q?fix(Core/Quest):=20Throw=20error=20if=20quest?=
 =?UTF-8?q?=5Ftemplate=20RewardItemId=20is=20not=20se=E2=80=A6=20(#17924)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

fix(Core/Quest): Throw error if quest_template RewardItemId is not set in order

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/17740
---
 src/server/game/Globals/ObjectMgr.cpp | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/src/server/game/Globals/ObjectMgr.cpp b/src/server/game/Globals/ObjectMgr.cpp
index 0849bf9e1..b176db33e 100644
--- a/src/server/game/Globals/ObjectMgr.cpp
+++ b/src/server/game/Globals/ObjectMgr.cpp
@@ -4942,6 +4942,25 @@ void ObjectMgr::LoadQuests()
             }
         }
 
+        for (uint8 j = 0; j < QUEST_REWARDS_COUNT; ++j)
+        {
+            if (!qinfo->RewardItemId[0] && qinfo->RewardItemId[j])
+            {
+                LOG_ERROR("sql.sql", "Quest {} has no `RewardItemId1` but has `RewardItem{}`. Reward item will not be loaded.",
+                                    qinfo->GetQuestId(), j + 1);
+            }
+            if (!qinfo->RewardItemId[1] && j > 1 && qinfo->RewardItemId[j])
+            {
+                LOG_ERROR("sql.sql", "Quest {} has no `RewardItemId2` but has `RewardItem{}`. Reward item will not be loaded.",
+                                    qinfo->GetQuestId(), j + 1);
+            }
+            if (!qinfo->RewardItemId[2] && j > 2 && qinfo->RewardItemId[j])
+            {
+                LOG_ERROR("sql.sql", "Quest {} has no `RewardItemId3` but has `RewardItem{}`. Reward item will not be loaded.",
+                                    qinfo->GetQuestId(), j + 1);
+            }
+        }
+
         for (uint8 j = 0; j < QUEST_REWARDS_COUNT; ++j)
         {
             uint32 id = qinfo->RewardItemId[j];