mirror of
https://github.com/mod-playerbots/azerothcore-wotlk.git
synced 2026-02-10 06:01:27 +00:00
fix(Core/ObjectGuid): prevent creating copies when looping objects (#6852)
This commit is contained in:
@@ -169,7 +169,7 @@ public:
|
||||
case DATA_RAZORGORE_THE_UNTAMED:
|
||||
if (state == DONE)
|
||||
{
|
||||
for (ObjectGuid const guid : EggList)
|
||||
for (ObjectGuid const& guid : EggList)
|
||||
if (GameObject* egg = instance->GetGameObject(guid))
|
||||
egg->SetPhaseMask(2, true);
|
||||
}
|
||||
|
||||
@@ -96,7 +96,7 @@ public:
|
||||
}
|
||||
break;
|
||||
case DATA_ERANIKUS_FIGHT:
|
||||
for (ObjectGuid const guid : _dragonkinList)
|
||||
for (ObjectGuid const& guid : _dragonkinList)
|
||||
{
|
||||
if (Creature* creature = instance->GetCreature(guid))
|
||||
if (instance->IsGridLoaded(creature->GetPositionX(), creature->GetPositionY()))
|
||||
|
||||
@@ -1086,7 +1086,7 @@ public:
|
||||
}
|
||||
}
|
||||
|
||||
for (ObjectGuid const guid : allianceGuardsGUID)
|
||||
for (ObjectGuid const& guid : allianceGuardsGUID)
|
||||
if (Creature* temp = ObjectAccessor::GetCreature(*me, guid))
|
||||
temp->DespawnOrUnsummon();
|
||||
|
||||
@@ -2415,7 +2415,7 @@ public:
|
||||
SaurfangGUID.Clear();
|
||||
}
|
||||
|
||||
for (ObjectGuid const guid : hordeGuardsGUID)
|
||||
for (ObjectGuid const& guid : hordeGuardsGUID)
|
||||
if (Creature* temp = ObjectAccessor::GetCreature(*me, guid))
|
||||
temp->DespawnOrUnsummon();
|
||||
|
||||
|
||||
@@ -699,7 +699,7 @@ public:
|
||||
if (counter > 12)
|
||||
{
|
||||
bool failed = false;
|
||||
for (ObjectGuid const guid : unitList)
|
||||
for (ObjectGuid const& guid : unitList)
|
||||
if (Unit* c = ObjectAccessor::GetUnit(*me, guid))
|
||||
if (c->HasAuraType(SPELL_AURA_PERIODIC_DUMMY))
|
||||
{
|
||||
@@ -753,7 +753,7 @@ public:
|
||||
Unit* getTrigger()
|
||||
{
|
||||
std::list<Unit*> tmpList;
|
||||
for (ObjectGuid const guid : unitList)
|
||||
for (ObjectGuid const& guid : unitList)
|
||||
if (Unit* c = ObjectAccessor::GetUnit(*me, guid))
|
||||
if (!c->HasAuraType(SPELL_AURA_PERIODIC_DUMMY))
|
||||
tmpList.push_back(c);
|
||||
@@ -772,7 +772,7 @@ public:
|
||||
{
|
||||
me->MonsterYell("Fire consumes! You've tried and failed. Let there be no doubt, justice prevailed!", LANG_UNIVERSAL, 0);
|
||||
me->PlayDirectSound(11967);
|
||||
for (ObjectGuid const guid : unitList)
|
||||
for (ObjectGuid const& guid : unitList)
|
||||
if (Unit* c = ObjectAccessor::GetUnit(*me, guid))
|
||||
c->RemoveAllAuras();
|
||||
|
||||
|
||||
@@ -220,7 +220,7 @@ public:
|
||||
{
|
||||
if (!m_uiAncientGemGUID.empty())
|
||||
{
|
||||
for (ObjectGuid const guid : m_uiAncientGemGUID)
|
||||
for (ObjectGuid const& guid : m_uiAncientGemGUID)
|
||||
{
|
||||
//don't know how long it expected
|
||||
DoRespawnGameObject(guid, DAY);
|
||||
|
||||
@@ -183,7 +183,7 @@ public:
|
||||
instance->LoadGrid(instancePositions[0].GetPositionX(), instancePositions[0].GetPositionY());
|
||||
instance->LoadGrid(instancePositions[1].GetPositionX(), instancePositions[1].GetPositionY());
|
||||
|
||||
for (ObjectGuid const guid : _prisonersSet)
|
||||
for (ObjectGuid const& guid : _prisonersSet)
|
||||
if (Creature* orc = instance->GetCreature(guid))
|
||||
{
|
||||
uint8 index = orc->GetDistance(instancePositions[0]) < 80.0f ? 0 : 1;
|
||||
@@ -193,7 +193,7 @@ public:
|
||||
orc->SetStandState(UNIT_STAND_STATE_STAND);
|
||||
}
|
||||
|
||||
for (ObjectGuid const guid : _initalFlamesSet)
|
||||
for (ObjectGuid const& guid : _initalFlamesSet)
|
||||
if (GameObject* gobject = instance->GetGameObject(guid))
|
||||
{
|
||||
gobject->SetRespawnTime(0);
|
||||
@@ -215,14 +215,14 @@ public:
|
||||
player->KilledMonsterCredit(NPC_LODGE_QUEST_TRIGGER);
|
||||
}
|
||||
|
||||
for (ObjectGuid const guid : _finalFlamesSet)
|
||||
for (ObjectGuid const& guid : _finalFlamesSet)
|
||||
if (GameObject* gobject = instance->GetGameObject(guid))
|
||||
{
|
||||
gobject->SetRespawnTime(0);
|
||||
gobject->UpdateObjectVisibility(true);
|
||||
}
|
||||
|
||||
for (ObjectGuid const guid : _prisonersSet)
|
||||
for (ObjectGuid const& guid : _prisonersSet)
|
||||
if (Creature* orc = instance->GetCreature(guid))
|
||||
if (roll_chance_i(25))
|
||||
orc->HandleEmoteCommand(EMOTE_ONESHOT_CHEER);
|
||||
|
||||
@@ -60,7 +60,7 @@ public:
|
||||
}
|
||||
|
||||
GuidSet eCopy = encounterNPCs;
|
||||
for (ObjectGuid const guid : eCopy)
|
||||
for (ObjectGuid const& guid : eCopy)
|
||||
if (Creature* creature = instance->GetCreature(guid))
|
||||
creature->DespawnOrUnsummon();
|
||||
}
|
||||
@@ -184,7 +184,7 @@ public:
|
||||
|
||||
// Xinef: delete all spawns
|
||||
GuidSet eCopy = encounterNPCs;
|
||||
for (ObjectGuid guid : eCopy)
|
||||
for (ObjectGuid const& guid : eCopy)
|
||||
if (Creature* creature = instance->GetCreature(guid))
|
||||
creature->DespawnOrUnsummon();
|
||||
}
|
||||
@@ -227,7 +227,7 @@ public:
|
||||
void SummonPortalKeeper()
|
||||
{
|
||||
Creature* rift = nullptr;
|
||||
for (ObjectGuid const guid : encounterNPCs)
|
||||
for (ObjectGuid const& guid : encounterNPCs)
|
||||
if (Creature* summon = instance->GetCreature(guid))
|
||||
if (summon->GetEntry() == NPC_TIME_RIFT)
|
||||
{
|
||||
|
||||
@@ -79,7 +79,7 @@ public:
|
||||
bDeepBreath = true;
|
||||
if( uiData == NOT_STARTED )
|
||||
{
|
||||
for (ObjectGuid guid : minions)
|
||||
for (ObjectGuid const& guid : minions)
|
||||
if (Creature* c = instance->GetCreature(guid))
|
||||
c->DespawnOrUnsummon();
|
||||
minions.clear();
|
||||
|
||||
@@ -187,7 +187,7 @@ public:
|
||||
events.ScheduleEvent(EVENT_PARALYZE, 15000);
|
||||
break;
|
||||
case EVENT_SWARMER_ATTACK:
|
||||
for (ObjectGuid guid : _swarmers)
|
||||
for (ObjectGuid const& guid : _swarmers)
|
||||
if (Creature* swarmer = me->GetMap()->GetCreature(guid))
|
||||
if (Unit* target = SelectTarget(SELECT_TARGET_RANDOM))
|
||||
swarmer->AI()->AttackStart(target);
|
||||
|
||||
@@ -63,7 +63,7 @@ public:
|
||||
{
|
||||
BossAI::EnterEvadeMode();
|
||||
|
||||
for (ObjectGuid guid : Eggs)
|
||||
for (ObjectGuid const& guid : Eggs)
|
||||
if (Creature* egg = me->GetMap()->GetCreature(guid))
|
||||
egg->Respawn();
|
||||
|
||||
|
||||
@@ -200,7 +200,7 @@ public:
|
||||
}
|
||||
|
||||
uint16 phase = 1;
|
||||
for (ObjectGuid guid : summons)
|
||||
for (ObjectGuid const& guid : summons)
|
||||
{
|
||||
if (Creature* summon = ObjectAccessor::GetCreature(*me, guid))
|
||||
phase |= summon->GetPhaseMask();
|
||||
|
||||
@@ -420,7 +420,7 @@ public:
|
||||
summons.RemoveNotExisting();
|
||||
if (!summons.empty())
|
||||
{
|
||||
for (ObjectGuid const summonGuid : summons)
|
||||
for (ObjectGuid const& summonGuid : summons)
|
||||
{
|
||||
Creature* summon = ObjectAccessor::GetCreature(*me, summonGuid);
|
||||
if (summon && summon->GetEntry() == NPC_FIRE_CYCLONE)
|
||||
@@ -556,7 +556,7 @@ public:
|
||||
uint8 iter = 0;
|
||||
if (!summons.empty())
|
||||
{
|
||||
for (ObjectGuid const summonGuid : summons)
|
||||
for (ObjectGuid const& summonGuid : summons)
|
||||
{
|
||||
Creature* summon = ObjectAccessor::GetCreature(*me, summonGuid);
|
||||
if (summon && summon->GetEntry() == NPC_FIRE_CYCLONE && iter == rand)
|
||||
@@ -636,7 +636,7 @@ public:
|
||||
return;
|
||||
}
|
||||
|
||||
for (ObjectGuid const guid : summons)
|
||||
for (ObjectGuid const& guid : summons)
|
||||
{
|
||||
Creature* tsunami = ObjectAccessor::GetCreature(*me, guid);
|
||||
if (!tsunami || tsunami->GetEntry() != NPC_FLAME_TSUNAMI)
|
||||
@@ -1129,7 +1129,7 @@ public:
|
||||
{
|
||||
summons.RemoveNotExisting();
|
||||
summons.DespawnEntry(NPC_TWILIGHT_WHELP);
|
||||
for (ObjectGuid const summonGuid : summons)
|
||||
for (ObjectGuid const& summonGuid : summons)
|
||||
{
|
||||
Creature const* summon = ObjectAccessor::GetCreature(*me, summonGuid);
|
||||
if (!summon || !summon->IsAlive() || summon->GetEntry() != NPC_TWILIGHT_EGG)
|
||||
|
||||
@@ -279,7 +279,7 @@ public:
|
||||
case INSTANCE_PROGRESS_CHAMPION_GROUP_DIED_3:
|
||||
// revert to INSTANCE_PROGRESS_INITIAL
|
||||
{
|
||||
for (ObjectGuid const guid : VehicleList)
|
||||
for (ObjectGuid const& guid : VehicleList)
|
||||
if (Creature* veh = instance->GetCreature(guid))
|
||||
{
|
||||
veh->DespawnOrUnsummon();
|
||||
@@ -567,7 +567,7 @@ public:
|
||||
{
|
||||
Counter = 0;
|
||||
InstanceProgress = INSTANCE_PROGRESS_CHAMPIONS_UNMOUNTED;
|
||||
for (ObjectGuid const guid : VehicleList)
|
||||
for (ObjectGuid const& guid : VehicleList)
|
||||
if (Creature* veh = instance->GetCreature(guid))
|
||||
veh->DespawnOrUnsummon();
|
||||
events.ScheduleEvent(EVENT_GRAND_CHAMPIONS_MOVE_SIDE, 0);
|
||||
|
||||
@@ -200,7 +200,7 @@ public:
|
||||
if( !IsHeroic() )
|
||||
events.RescheduleEvent(EVENT_RESPAWN_SPHERE, 4000);
|
||||
|
||||
for (ObjectGuid guid : summons)
|
||||
for (ObjectGuid const& guid : summons)
|
||||
if (pInstance)
|
||||
if (Creature* c = pInstance->instance->GetCreature(guid))
|
||||
{
|
||||
|
||||
@@ -73,7 +73,7 @@ public:
|
||||
|
||||
// move corpses
|
||||
const ObjectGuid npcs[4] = { NPC_IcehowlGUID, NPC_JaraxxusGUID, NPC_LightbaneGUID, NPC_DarkbaneGUID };
|
||||
for (const ObjectGuid i : npcs)
|
||||
for (ObjectGuid const& i : npcs)
|
||||
{
|
||||
if (Creature* c = instance->GetCreature(i))
|
||||
{
|
||||
@@ -402,7 +402,7 @@ public:
|
||||
InstanceProgress = INSTANCE_PROGRESS_FACTION_CHAMPIONS_DEAD;
|
||||
events.RescheduleEvent(EVENT_SCENE_FACTION_CHAMPIONS_DEAD, 2500);
|
||||
|
||||
for (ObjectGuid guid : NPC_ChampionGUIDs)
|
||||
for (ObjectGuid const& guid : NPC_ChampionGUIDs)
|
||||
if (Creature* c = instance->GetCreature(guid))
|
||||
c->DespawnOrUnsummon(15000);
|
||||
NPC_ChampionGUIDs.clear();
|
||||
@@ -455,7 +455,7 @@ public:
|
||||
{
|
||||
EncounterStatus = IN_PROGRESS;
|
||||
AchievementTimer = 0;
|
||||
for (ObjectGuid guid : NPC_ChampionGUIDs)
|
||||
for (ObjectGuid const& guid : NPC_ChampionGUIDs)
|
||||
if (Creature* c = instance->GetCreature(guid))
|
||||
if (!c->IsInCombat())
|
||||
if (Unit* target = c->SelectNearestTarget(200.0f))
|
||||
@@ -1093,7 +1093,7 @@ public:
|
||||
}
|
||||
case EVENT_CHAMPIONS_ATTACK:
|
||||
{
|
||||
for (ObjectGuid guid : NPC_ChampionGUIDs)
|
||||
for (ObjectGuid const& guid : NPC_ChampionGUIDs)
|
||||
if (Creature* c = instance->GetCreature(guid))
|
||||
{
|
||||
c->SetReactState(REACT_AGGRESSIVE);
|
||||
@@ -1493,7 +1493,7 @@ public:
|
||||
case INSTANCE_PROGRESS_JARAXXUS_DEAD:
|
||||
if( Creature* c = instance->GetCreature(NPC_BarrettGUID) )
|
||||
c->SetFlag(UNIT_NPC_FLAGS, UNIT_NPC_FLAG_GOSSIP);
|
||||
for (ObjectGuid guid : NPC_ChampionGUIDs)
|
||||
for (ObjectGuid const& guid : NPC_ChampionGUIDs)
|
||||
if (Creature* c = instance->GetCreature(guid))
|
||||
c->DespawnOrUnsummon();
|
||||
NPC_ChampionGUIDs.clear();
|
||||
|
||||
@@ -958,7 +958,7 @@ public:
|
||||
|
||||
TSSpawnPos.GetAngle(&TSMidPos);
|
||||
|
||||
for (ObjectGuid guid : summons)
|
||||
for (ObjectGuid const& guid : summons)
|
||||
if (Creature* c = pInstance->instance->GetCreature(guid))
|
||||
{
|
||||
float hx, hy, hz, ho;
|
||||
@@ -974,7 +974,7 @@ public:
|
||||
if (pInstance)
|
||||
if (Creature* c = pInstance->instance->GetCreature(pInstance->GetGuidData(DATA_SINDRAGOSA_GUID)))
|
||||
{
|
||||
for (ObjectGuid guid : summons)
|
||||
for (ObjectGuid const& guid : summons)
|
||||
if (Creature* s = pInstance->instance->GetCreature(guid))
|
||||
if (s->IsAlive())
|
||||
Unit::Kill(c, s);
|
||||
@@ -1026,7 +1026,7 @@ public:
|
||||
me->SetFacingTo(5.26f);
|
||||
me->SetOrientation(5.26f);
|
||||
me->SetHomePosition(*me);
|
||||
for (ObjectGuid guid : summons)
|
||||
for (ObjectGuid const& guid : summons)
|
||||
if (Creature* c = pInstance->instance->GetCreature(guid))
|
||||
{
|
||||
c->SetFacingTo(5.26f);
|
||||
@@ -1056,7 +1056,7 @@ public:
|
||||
float offset = frand(0.0f, 10.0f);
|
||||
c->GetMotionMaster()->MovePoint(0, 1047.0f + offset, 118.0f + offset, 628.2f);
|
||||
c->SetHomePosition(*me);
|
||||
for (ObjectGuid guid : summons)
|
||||
for (ObjectGuid const& guid : summons)
|
||||
if (Creature* s = pInstance->instance->GetCreature(guid))
|
||||
{
|
||||
if (s->GetEntry() == NPC_FALLEN_WARRIOR)
|
||||
|
||||
@@ -369,7 +369,7 @@ public:
|
||||
{
|
||||
// shouldn't be casted on any victim of summoned mobs
|
||||
bool valid = true;
|
||||
for (ObjectGuid const guid : summons)
|
||||
for (ObjectGuid const& guid : summons)
|
||||
if (Creature* c = ObjectAccessor::GetCreature(*me, guid))
|
||||
if (c->IsAlive() && c->GetVictim() && c->GetVictim()->GetGUID() == plr->GetGUID())
|
||||
{
|
||||
|
||||
@@ -191,7 +191,7 @@ public:
|
||||
|
||||
bool IsValidExplosionTarget(WorldObject* target)
|
||||
{
|
||||
for (ObjectGuid const guid : blockList)
|
||||
for (ObjectGuid const& guid : blockList)
|
||||
{
|
||||
if (target->GetGUID() == guid)
|
||||
return false;
|
||||
|
||||
@@ -291,7 +291,7 @@ public:
|
||||
events.RepeatEvent(30000);
|
||||
else
|
||||
{
|
||||
for (ObjectGuid guid : summons)
|
||||
for (ObjectGuid const& guid : summons)
|
||||
if (Creature* sv = ObjectAccessor::GetCreature(*me, guid))
|
||||
{
|
||||
sv->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NON_ATTACKABLE);
|
||||
|
||||
@@ -2321,7 +2321,7 @@ public:
|
||||
|
||||
void RemoveAll()
|
||||
{
|
||||
for (ObjectGuid guid : FlameList)
|
||||
for (ObjectGuid const& guid : FlameList)
|
||||
if (Creature* c = ObjectAccessor::GetCreature(*me, guid))
|
||||
c->DespawnOrUnsummon();
|
||||
FlameList.clear();
|
||||
|
||||
@@ -1219,7 +1219,7 @@ void instance_ulduar::instance_ulduar_InstanceMapScript::SpawnLeviathanEncounter
|
||||
{
|
||||
if (!_leviathanVehicles.empty())
|
||||
{
|
||||
for (ObjectGuid guid : _leviathanVehicles)
|
||||
for (ObjectGuid const& guid : _leviathanVehicles)
|
||||
if (Creature* cr = instance->GetCreature(guid))
|
||||
if (Vehicle* veh = cr->GetVehicleKit())
|
||||
veh->Dismiss();
|
||||
|
||||
@@ -209,7 +209,7 @@ public:
|
||||
bool bIsWaterElementsAlive = false;
|
||||
if (!globules.empty())
|
||||
{
|
||||
for (ObjectGuid const guid : globules)
|
||||
for (ObjectGuid const& guid : globules)
|
||||
if (Creature* pTemp = ObjectAccessor::GetCreature(*me, guid))
|
||||
if (pTemp->IsAlive())
|
||||
{
|
||||
|
||||
@@ -124,7 +124,7 @@ public:
|
||||
{
|
||||
bool found = false;
|
||||
if (pInstance)
|
||||
for (ObjectGuid guid : spheres)
|
||||
for (ObjectGuid const& guid : spheres)
|
||||
if (Creature* c = pInstance->instance->GetCreature(guid))
|
||||
if (me->GetDistance(c) < 3.0f)
|
||||
{
|
||||
|
||||
@@ -434,7 +434,7 @@ public:
|
||||
DoUpdateWorldState(WORLD_STATE_VH_PRISON_STATE, (uint32)GateHealth);
|
||||
DoUpdateWorldState(WORLD_STATE_VH_WAVE_COUNT, (uint32)WaveCount);
|
||||
|
||||
for (ObjectGuid guid : GO_ActivationCrystalGUID)
|
||||
for (ObjectGuid const& guid : GO_ActivationCrystalGUID)
|
||||
if (GameObject* go = instance->GetGameObject(guid))
|
||||
{
|
||||
HandleGameObject(ObjectGuid::Empty, false, go); // not used yet
|
||||
@@ -528,7 +528,7 @@ public:
|
||||
CLEANED = true;
|
||||
|
||||
// reset defense crystals
|
||||
for (ObjectGuid guid : GO_ActivationCrystalGUID)
|
||||
for (ObjectGuid const& guid : GO_ActivationCrystalGUID)
|
||||
if (GameObject* go = instance->GetGameObject(guid))
|
||||
{
|
||||
HandleGameObject(ObjectGuid::Empty, false, go); // not used yet
|
||||
@@ -555,7 +555,7 @@ public:
|
||||
NPC_PortalGUID.Clear();
|
||||
|
||||
// remove trash
|
||||
for (ObjectGuid guid : trashMobs)
|
||||
for (ObjectGuid const& guid : trashMobs)
|
||||
if (Creature* c = instance->GetCreature(guid))
|
||||
c->DespawnOrUnsummon();
|
||||
|
||||
|
||||
@@ -171,7 +171,7 @@ public:
|
||||
void CheckSummons()
|
||||
{
|
||||
bool allow = true;
|
||||
for (ObjectGuid guid : summons)
|
||||
for (ObjectGuid const& guid : summons)
|
||||
if (Creature* cr = ObjectAccessor::GetCreature(*me, guid))
|
||||
if (cr->IsAlive())
|
||||
allow = false;
|
||||
|
||||
@@ -176,7 +176,7 @@ public:
|
||||
if (action == ACTION_BIND_MINIONS)
|
||||
me->CastSpell(me, SPELL_ARTRUIS_BINDING, true);
|
||||
|
||||
for (ObjectGuid const guid : summons)
|
||||
for (ObjectGuid const& guid : summons)
|
||||
{
|
||||
Creature* minion = ObjectAccessor::GetCreature(*me, guid);
|
||||
if (minion && minion->IsAlive())
|
||||
|
||||
@@ -187,7 +187,7 @@ public:
|
||||
|
||||
if (type == DATA_SHADE_OF_AKAMA && state == DONE)
|
||||
{
|
||||
for (ObjectGuid const guid : ashtongueGUIDs)
|
||||
for (ObjectGuid const& guid : ashtongueGUIDs)
|
||||
if (Creature* ashtongue = instance->GetCreature(guid))
|
||||
ashtongue->setFaction(FACTION_ASHTONGUE);
|
||||
}
|
||||
@@ -293,7 +293,7 @@ public:
|
||||
|
||||
void HandleEffectRemove(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)
|
||||
{
|
||||
for (ObjectGuid const guid : _turtleSet)
|
||||
for (ObjectGuid const& guid : _turtleSet)
|
||||
if (Creature* turtle = ObjectAccessor::GetCreature(*GetUnitOwner(), guid))
|
||||
{
|
||||
turtle->TauntFadeOut(GetUnitOwner());
|
||||
|
||||
@@ -218,7 +218,7 @@ public:
|
||||
|
||||
void ResetPrisoners(GuidSet prisoners)
|
||||
{
|
||||
for (ObjectGuid guid : prisoners)
|
||||
for (ObjectGuid const& guid : prisoners)
|
||||
if (Creature* prisoner = instance->GetCreature(guid))
|
||||
ResetPrisoner(prisoner);
|
||||
}
|
||||
@@ -300,7 +300,7 @@ public:
|
||||
|
||||
void ActivatePrisoners(GuidSet prisoners)
|
||||
{
|
||||
for (ObjectGuid guid : prisoners)
|
||||
for (ObjectGuid const& guid : prisoners)
|
||||
if (Creature* prisoner = instance->GetCreature(guid))
|
||||
{
|
||||
prisoner->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_IMMUNE_TO_PC | UNIT_FLAG_IMMUNE_TO_NPC | UNIT_FLAG_NON_ATTACKABLE);
|
||||
|
||||
@@ -118,7 +118,7 @@ public:
|
||||
{
|
||||
if (state == IN_PROGRESS)
|
||||
{
|
||||
for (ObjectGuid const guid : _wardersSet)
|
||||
for (ObjectGuid const& guid : _wardersSet)
|
||||
if (Creature* warder = instance->GetCreature(guid))
|
||||
if (warder->IsAlive())
|
||||
{
|
||||
@@ -128,7 +128,7 @@ public:
|
||||
}
|
||||
else
|
||||
{
|
||||
for (ObjectGuid const guid : _cubesSet)
|
||||
for (ObjectGuid const& guid : _cubesSet)
|
||||
if (GameObject* cube = instance->GetGameObject(guid))
|
||||
cube->SetFlag(GAMEOBJECT_FLAGS, GO_FLAG_NOT_SELECTABLE);
|
||||
|
||||
@@ -149,12 +149,12 @@ public:
|
||||
magtheridon->SetInCombatWithZone();
|
||||
break;
|
||||
case DATA_ACTIVATE_CUBES:
|
||||
for (ObjectGuid const guid : _cubesSet)
|
||||
for (ObjectGuid const& guid : _cubesSet)
|
||||
if (GameObject* cube = instance->GetGameObject(guid))
|
||||
cube->RemoveFlag(GAMEOBJECT_FLAGS, GO_FLAG_NOT_SELECTABLE);
|
||||
break;
|
||||
case DATA_COLLAPSE:
|
||||
for (ObjectGuid const guid : _columnSet)
|
||||
for (ObjectGuid const& guid : _columnSet)
|
||||
if (GameObject* column = instance->GetGameObject(guid))
|
||||
column->SetGoState(GOState(data));
|
||||
break;
|
||||
|
||||
@@ -105,7 +105,7 @@ public:
|
||||
|
||||
void HandleEffectRemove(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)
|
||||
{
|
||||
for (ObjectGuid const guid : _falconSet)
|
||||
for (ObjectGuid const& guid : _falconSet)
|
||||
if (Creature* falcon = ObjectAccessor::GetCreature(*GetUnitOwner(), guid))
|
||||
{
|
||||
falcon->TauntFadeOut(GetUnitOwner());
|
||||
|
||||
@@ -1097,7 +1097,7 @@ public:
|
||||
{
|
||||
if (!summons.empty())
|
||||
{
|
||||
for (ObjectGuid guid : summons)
|
||||
for (ObjectGuid const& guid : summons)
|
||||
if (Creature* cr = ObjectAccessor::GetCreature(*me, guid))
|
||||
{
|
||||
float x, y, z, o;
|
||||
|
||||
@@ -983,7 +983,7 @@ public:
|
||||
{
|
||||
if (!Patients.empty())
|
||||
{
|
||||
for (ObjectGuid const guid : Patients)
|
||||
for (ObjectGuid const& guid : Patients)
|
||||
{
|
||||
if (Creature* patient = ObjectAccessor::GetCreature(*me, guid))
|
||||
patient->setDeathState(JUST_DIED);
|
||||
|
||||
Reference in New Issue
Block a user